Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

CLI signer does not work #8393

Closed
tomusdrw opened this issue Apr 13, 2018 · 2 comments · Fixed by paritytech/primitives#33, paritytech/primitives#34 or #8682
Closed

CLI signer does not work #8393

tomusdrw opened this issue Apr 13, 2018 · 2 comments · Fixed by paritytech/primitives#33, paritytech/primitives#34 or #8682
Labels
F2-bug 🐞 The client fails to follow expected behavior. M6-rpcapi 📣 RPC API. P5-sometimesoon 🌲 Issue is worth doing soon.
Milestone
2.0 Ethereum

Comments

@tomusdrw
Copy link
Collaborator

The CLI signer does not work, sends invalid requests to RPC. IMHO it's important to get it working since we are separating the UI and there will be no other way to confrim the request.
@tomusdrw tomusdrw added F2-bug 🐞 The client fails to follow expected behavior. P5-sometimesoon 🌲 Issue is worth doing soon. M6-rpcapi 📣 RPC API. labels Apr 13, 2018
@Tbaut Tbaut added this to the 1.11 milestone Apr 13, 2018
@5chdn 5chdn modified the milestones: 1.11, 1.12 Apr 24, 2018
ascjones added a commit to paritytech/primitives that referenced this issue May 15, 2018
@ascjones
Prefix Ox for lower hex for alternate flag
84026f4 
Should fix openethereum/parity-ethereum#8393
As per https://doc.rust-lang.org/std/fmt/trait.LowerHex.html
@ascjones ascjones mentioned this issue May 15, 2018
Merged
tomusdrw pushed a commit to paritytech/primitives that referenced this issue May 21, 2018
@ascjones @tomusdrw
Prefix 0x for lower hex with alternate flag (#33)
1ecd832 
* Prefix `Ox` for lower hex for alternate flag

Should fix openethereum/parity-ethereum#8393
As per https://doc.rust-lang.org/std/fmt/trait.LowerHex.html

* Use hex alternate format for debug
@ascjones
Copy link
Contributor

ascjones commented May 21, 2018 •
edited
Loading

@tomusdrw still need to update to a new version of ethereum-types/uint in order to complete the fix

@ascjones ascjones reopened this May 21, 2018
@ascjones ascjones mentioned this issue May 21, 2018
Merged
@ascjones
Copy link
Contributor

This issue keeps closing automatically by github from the other repo issue, probably because of the fix keyword.

@ascjones ascjones reopened this May 22, 2018
@ascjones ascjones mentioned this issue May 22, 2018
Merged
@ascjones ascjones added A0-pleasereview 🤓 Pull request needs code review. and removed A0-pleasereview 🤓 Pull request needs code review. labels May 22, 2018
dvdplm pushed a commit to paritytech/parity-common that referenced this issue Jul 13, 2018
@ascjones @tomusdrw
Prefix 0x for lower hex with alternate flag (#33)
f1912b8 
* Prefix `Ox` for lower hex for alternate flag

Should fix openethereum/parity-ethereum#8393
As per https://doc.rust-lang.org/std/fmt/trait.LowerHex.html

* Use hex alternate format for debug
dvdplm pushed a commit to paritytech/parity-common that referenced this issue Jul 13, 2018
@ascjones @tomusdrw
Prefix 0x for lower hex with alternate flag (#33)
24b94af 
* Prefix `Ox` for lower hex for alternate flag

Should fix openethereum/parity-ethereum#8393
As per https://doc.rust-lang.org/std/fmt/trait.LowerHex.html

* Use hex alternate format for debug
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
F2-bug 🐞 The client fails to follow expected behavior. M6-rpcapi 📣 RPC API. P5-sometimesoon 🌲 Issue is worth doing soon.
Projects
None yet
Milestone
2.0 Ethereum
4 participants
@ascjones @tomusdrw @5chdn @Tbaut