This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Add error for sendRawTransaction and estimateGas #3194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A0-pleasereview 🤓
rphmeier
reviewed
Nov 4, 2016
| @@ -271,6 +272,14 @@ pub fn from_transaction_error(error: EthcoreError) -> Error { | |||
| } | |||
| } | |||
|
|
|||
| pub fn from_rlp_error(error: DecoderError) -> Error { | |||
There was a problem hiding this comment.
why are so many of the functions in the error module suffixed with error? it makes it a bit awkward when calling (error::from_rlp_error() vs error::from_rlp) as well as being inconsistent with other functions in the module, e.g. error::signer_disabled
There was a problem hiding this comment.
maybe make an issue to cleanup this error naming?
There was a problem hiding this comment.
error::from_rlp looks time as error is being converted from Rlp
There was a problem hiding this comment.
right, it should be error::bad_rlp or something like that
There was a problem hiding this comment.
gavofyork
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3122