In-browser signing support #3231

tomusdrw · 2016-11-07T14:39:48Z

Altered eth_accounts to return also addresses from Address Book.

I'm open to suggestion how this could be done in more elegant way. Probably in future when we have Dapps authorization this will be easy.

derhuerst · 2016-11-07T14:56:29Z

js/src/redux/providers/signerMiddleware.js

+    if (wallet && payload.transaction) {
+      const { transaction } = payload;
+      this._api.parity
+        .nextNonce(transaction.from)


This will be called unnecessarily if transaction.nonce is not zero. This would work:

(transaction.nonce.isZero() ? this._api.parity.nextNonce(transaction.from) : Promise.resolve(transaction.nonce) ).then(nonce => {…})

Is Promise.resolve(...).then executed in next event loop tick? The problem is that wallet derivation takes significant amount of time and UI is not refreshed before this happens. So it needs to be wrapped with setTimeout(..., 0). Will try that and see if it works.

Promises always resolve on nextTick afaik.

Also, async code can still block the whole UI if it runs for a while. This should be in a web worker.

derhuerst · 2016-11-07T15:01:45Z

js/src/redux/providers/signerMiddleware.js

@@ -82,3 +117,15 @@ export default class SignerMiddleware {
      });
  }
 }
+
+function asHex (val) {


To keep the code DRY, it would be great if this was part of /api/format/input -> inHex.

derhuerst · 2016-11-07T15:03:55Z

js/src/util/wallet.js

+
+    const { kdf } = json.crypto;
+    const kdfparams = json.crypto.kdfparams || {};
+    const pwd = new Buffer(password);


new Buffer is deprecated, use Butter.from.

derhuerst · 2016-11-07T15:05:21Z

js/src/util/wallet.js

+    }
+
+    const ciphertext = new Buffer(json.crypto.ciphertext, 'hex');
+    const mac = ethUtil.sha3(Buffer.concat([derivedKey.slice(16, 32), ciphertext]));


sha3 is available in /api/util/sha3.

derhuerst · 2016-11-07T15:08:22Z

js/src/util/wallet.js

+  signTransaction (transaction) {
+    const tx = new Transaction(transaction);
+    tx.sign(this.seed);
+    return `0x${tx.serialize().toString('hex')}`;


Use inHex from /api/format/input.

derhuerst · 2016-11-07T15:18:40Z

js/src/util/wallet.js

+import scrypt from 'scryptsy';
+import Transaction from 'ethereumjs-tx';
+import crypto from 'crypto';
+import aes from 'browserify-aes';


It seems like you can import just browserify-aes/decrypter. Also import { createDecipheriv } from … seems to be sufficient.

derhuerst · 2016-11-07T15:31:13Z

Note: Just had a formal look at the code, didn't check if the UI works for me.

derhuerst · 2016-11-07T15:37:54Z

js/src/util/wallet.js

 import scrypt from 'scryptsy';
 import Transaction from 'ethereumjs-tx';
-import crypto from 'crypto';
-import aes from 'browserify-aes';
+import { pbkdf2Sync } from 'crypto';


derhuerst · 2016-11-07T15:39:33Z

js/src/util/wallet.js

@@ -41,27 +43,26 @@ export class Wallet {
      if (kdfparams.prf !== 'hmac-sha256') {
        throw new Error('Unsupported parameters to PBKDF2');
      }
-      derivedKey = crypto.pbkdf2Sync(pwd, salt, kdfparams.c, kdfparams.dklen, 'sha256');
+      derivedKey = pbkdf2Sync(pwd, salt, kdfparams.c, kdfparams.dklen, 'sha256');


There is crypto.pbkdf2 (which is async). Have you checked if the UI still blocks with that one? (It could still be one expensive block even if async, but it sounds promising.)

Crypto is implemented in JS, so it will run in single a single thread anyway. The API is there for node compatibility: https://github.com/crypto-browserify/pbkdf2/blob/master/browser.js#L13

derhuerst · 2016-11-07T15:45:12Z

js/src/util/wallet.js

@@ -75,7 +76,7 @@ export class Wallet {
  signTransaction (transaction) {
    const tx = new Transaction(transaction);
    tx.sign(this.seed);


We could use ethereumjs-util directly (slightly more code in our codebase, but smaller dependency tree), as Transaction.prototype.sign just calls two functions.

jacogr · 2016-11-07T16:44:18Z

js/src/api/rpc/parity/parity.js

@@ -176,6 +176,12 @@ export default class Parity {
      .then(outAddress);
  }

+  nextNonce (account) {


We should add the function under js/jsonrpc/ as well

jacogr · 2016-11-07T16:44:39Z

js/src/api/rpc/signer/signer.js

@@ -27,6 +27,11 @@ export default class Signer {
      .execute('signer_confirmRequest', inNumber16(requestId), options, password);
  }

+  confirmRequestRaw (requestId, data) {


Same js/jsonrpc comment as above

gavofyork · 2016-11-07T17:35:47Z

would like an additional tier of "external" accounts; those that are owned but which don't have a key. they should go on the main accounts page, but in a second section. signer should include allowing upload of a json key (ideally only needed once per key and stored in local storage, but that can be a second PR), but also just copy'n'pasting the unsigned hex and providing the signature (or signed hex) into a text input. this latter point is extremely relevant to cold-wallets.

tomusdrw · 2016-11-07T18:38:51Z

Created a separate issue for those 3 additional tasks. Let me know if you feel that any of them should be part of this PR.

jacogr · 2016-11-07T20:28:24Z

Closes https://github.com/ethcore/parity/issues/2688

gavofyork · 2016-11-08T10:41:25Z

rpc/src/v1/impls/eth.rs

@@ -339,7 +340,10 @@ impl<C, SN: ?Sized, S: ?Sized, M, EM> Eth for EthClient<C, SN, S, M, EM> where

 		let store = take_weak!(self.accounts);
 		let accounts = try!(store.accounts().map_err(|e| errors::internal("Could not fetch accounts.", e)));
-		Ok(accounts.into_iter().map(Into::into).collect())
+		let addresses = try!(store.accounts_info().map_err(|e| errors::internal("Could not fetch accounts.", e)));


accounts_info should always be a superset of accounts, so there should be no need to merge the two.

Good catch. It should be addresses_info - fixed and added test.

gavofyork · 2016-11-08T10:42:10Z

rust side looks good aside from a minor qualm.

Conflicts: rpc/src/v1/impls/signer.rs rpc/src/v1/traits/signer.rs

* Added new Deploy Contract page // Use Brace in React #2276 * Adding Web Wrokers WIP * Compiling Solidity code // Getting mandatory params #2276 * Working editor and deployment #2276 * WIP : displaying source code * Added Solidity hightling, editor component in UI * Re-adding the standard Deploy Modal #2276 * Using MobX in Contract Edition // Save to Localstorage #2276 * User select Solidity version #2276 * Loading Solidity versions and closing worker properly #2276 * Adds export to solidity editor #2276 * Adding Import to Contract Editor #2276 * Persistent Worker => Don't load twice Solidity Code #2276 * UI Fixes * Editor tweaks * Added Details with ABI in Contract view * Adds Save capabilities to contract editor // WIP on Load #3279 * Working Load and Save contracts... #3231 * Adding loader of Snippets // Export with name #3279 * Added snippets / Importing from files and from URL * Fix wrong ID in saved Contract * Fix lint * Fixed Formal errors as warning #3279 * Fixing lint issues * Use NPM Module for valid URL (fixes linting issue too) * Don't clobber tests.

Tomasz Drwięga added 3 commits November 7, 2016 11:13

Signer RAW confirmations

139bb4a

Returning address book as eth_accounts

1ebad2d

UI support for in-browser signing

fcde4f6

tomusdrw added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. M6-ui labels Nov 7, 2016

derhuerst reviewed Nov 7, 2016

View reviewed changes

derhuerst mentioned this pull request Nov 7, 2016

Key derivation should be done in webworker to prevent stalled UI #3233

Closed

Post review fixes

e13e357

derhuerst reviewed Nov 7, 2016

View reviewed changes

jacogr reviewed Nov 7, 2016

View reviewed changes

Adding new methods to jsonrpc

11dca9a

tomusdrw mentioned this pull request Nov 7, 2016

External accounts support #3243

Closed

4 tasks

gavofyork reviewed Nov 8, 2016

View reviewed changes

jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 8, 2016

Fixing eth_accounts

b1ca593

tomusdrw added A0-pleasereview 🤓 Pull request needs code review. and removed A8-looksgood 🦄 Pull request is reviewed well. labels Nov 8, 2016

gavofyork added A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 9, 2016

Merge branch 'master' into signer-raw

7dbae62

Conflicts: rpc/src/v1/impls/signer.rs rpc/src/v1/traits/signer.rs

tomusdrw added A0-pleasereview 🤓 Pull request needs code review. and removed A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. labels Nov 9, 2016

tomusdrw self-assigned this Nov 9, 2016

tomusdrw added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 9, 2016

Deterministic accounts ordering

def8ae9

tomusdrw added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Nov 9, 2016

ngotchac added a commit that referenced this pull request Nov 9, 2016

Working Load and Save contracts... #3231

e3d1c55

gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 10, 2016

gavofyork merged commit 2f98169 into master Nov 10, 2016

gavofyork deleted the signer-raw branch November 10, 2016 10:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

In-browser signing support #3231

In-browser signing support #3231

tomusdrw commented Nov 7, 2016 •

edited

Loading

derhuerst Nov 7, 2016

tomusdrw Nov 7, 2016 •

edited

Loading

derhuerst Nov 7, 2016

derhuerst Nov 7, 2016

derhuerst Nov 7, 2016 •

edited

Loading

derhuerst Nov 7, 2016

derhuerst Nov 7, 2016 •

edited

Loading

derhuerst Nov 7, 2016

derhuerst commented Nov 7, 2016

derhuerst Nov 7, 2016

derhuerst Nov 7, 2016

tomusdrw Nov 7, 2016

derhuerst Nov 7, 2016

derhuerst Nov 7, 2016

jacogr Nov 7, 2016

jacogr Nov 7, 2016

gavofyork commented Nov 7, 2016 •

edited

Loading

tomusdrw commented Nov 7, 2016

jacogr commented Nov 7, 2016

gavofyork Nov 8, 2016

tomusdrw Nov 8, 2016

gavofyork commented Nov 8, 2016

In-browser signing support #3231

In-browser signing support #3231

Conversation

tomusdrw commented Nov 7, 2016 • edited Loading

Choose a reason for hiding this comment

tomusdrw Nov 7, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

derhuerst Nov 7, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

derhuerst Nov 7, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

derhuerst commented Nov 7, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gavofyork commented Nov 7, 2016 • edited Loading

tomusdrw commented Nov 7, 2016

jacogr commented Nov 7, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gavofyork commented Nov 8, 2016

tomusdrw commented Nov 7, 2016 •

edited

Loading

tomusdrw Nov 7, 2016 •

edited

Loading

derhuerst Nov 7, 2016 •

edited

Loading

derhuerst Nov 7, 2016 •

edited

Loading

gavofyork commented Nov 7, 2016 •

edited

Loading