Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Solidity Compiler in UI #3279

Merged
merged 30 commits into from Nov 11, 2016
Merged

Solidity Compiler in UI #3279

merged 30 commits into from Nov 11, 2016

Conversation

ngotchac
Copy link
Contributor

@ngotchac ngotchac commented Nov 8, 2016

See it in action here : https://youtu.be/RIZJA6A8Iwk

This PR would close #2276 and #3196

It introduces a new part of the Application to write Solidity contracts and compile them directly here.
The source code is then saved and can be found in the contract view.

In progress:

  • Import from Solidity file
  • Export to Solidity file
  • Save current code to localstorage with a name
  • Load from previously saved files
  • Load from given snippets

@ngotchac ngotchac added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. M6-ui labels Nov 8, 2016
@gavofyork
Copy link
Contributor

maybe see if you can integrate browser-solidity directly?

@ngotchac
Copy link
Contributor Author

ngotchac commented Nov 9, 2016

There's a lot going on in browser-solidity, might not be necessary for a first approach. Plus, in this PR, everything is run in a Web Worker, which isn't necessarily the case with browser solidity.

@ngotchac ngotchac added the A0-pleasereview 🤓 Pull request needs code review. label Nov 10, 2016
@ngotchac ngotchac removed the A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. label Nov 10, 2016
@jacogr
Copy link
Contributor

jacogr commented Nov 10, 2016

Not sure the ABI, contract, etc should show when there is a compiler error.

parity 2016-11-10 15-42-28

@ngotchac
Copy link
Contributor Author

Right, that's because it's not really an error but a formal verification error... Will improve!

@jacogr
Copy link
Contributor

jacogr commented Nov 10, 2016

Tests still failing. In addition, not quite sure if you addressed the small UI-related issues I raised in Slack - if still busy, just move it to in-progress, alternatively I'll give it a go again in the morning.

@ngotchac
Copy link
Contributor Author

@jacogr Yep, they should be addressed now

@gavofyork
Copy link
Contributor

js-tests failing.

@gavofyork
Copy link
Contributor

gavofyork commented Nov 11, 2016

i think you've clobbered the tests submodule commit. ensure your parity/ethcore/res/ethereum/tests is up to date with master.

@gavofyork gavofyork added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. and removed A0-pleasereview 🤓 Pull request needs code review. A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Nov 11, 2016
@gavofyork gavofyork added A9-buythatmanabeer 🍻 Pull request is reviewed well and worth buying the author a beer. and removed A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. labels Nov 11, 2016
@jacogr jacogr merged commit 0e4ef53 into master Nov 11, 2016
@jacogr jacogr deleted the ng-solidity-compiler branch November 11, 2016 14:00
@gavofyork gavofyork added the B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. label Nov 11, 2016
@TbLtzk
Copy link

TbLtzk commented Nov 30, 2016

Awesome! I'd really love to try it. I've seen it's been merged to master, but I don't see it in any release notes. Is it released, or what is the targeted release version?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A9-buythatmanabeer 🍻 Pull request is reviewed well and worth buying the author a beer. B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contract deployment should allow us to compile Solidity directly
4 participants