Export accounts as JSON or CSV #2866
Conversation
|
Couple of comments -
|
|
what would those APIs do? i think it's probably fine to do it in the browser from what i can see |
👍 JSON feels a lot more robust than CSV. Beginners won't care what format it is and advanced users may fiddle with both. |
|
I guess you're right about the CSV file... I was just thinking of users who uses Excel a lot who wants to copy/paste easily a vector of addresses... |
|
Shouldn't the import be in another issue ? It needs more work (nice file upload UI at least), and would only be available for the Address Book without full export of accounts (keys) |
|
Import logged here : #2885 |
| } | ||
| } | ||
|
|
||
| handleExport = () => { |
There was a problem hiding this comment.
is this abstraction worth it? also getExtension feels like we're not going to need it for now.
| ? content | ||
| : JSON.stringify(content, null, 4); | ||
| const text = this.contentAsString(content, filetype); | ||
| const extension = this.getExtension(filetype); | ||
|
|
||
| const blob = new Blob([ text ], { type: 'text/plain;charset=utf-8' }); |
There was a problem hiding this comment.
shouldn't the mime type corresponding to filetype be passed as type?
|
@derhuerst Comments fixed! |
|
Changes Unknown when pulling 6b2cffd on ng-accounts-backup into * on master*. |
derhuerst
added
A8-looksgood 🦄
|
Happy to have imports seperated, just would like to keep this back a bit until that is ready - since it will be first thing people ask for. |
gavofyork
added
A1-onice 🌨
jacogr
added
A1-onice 🌨
|
are we doing import functionality too or is this going to stay onice forever? |
|
Yep ; should be easy after #3279 gets merged |
|
was merged 5 days ago... :-) |
ngotchac
added
A0-pleasereview 🤓
gavofyork
added
A8-looksgood 🦄
Closes #2147
Enables the user to export its Accounts to CSV or JSON files.