This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Additional snapshot sync checks #3318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkpar
added
A0-pleasereview 🤓
rphmeier
reviewed
Nov 9, 2016
| let best_block = io.chain().chain_info().best_block_number; | ||
| // Make sure the snapshot block is not too far away from our best block, network best block and | ||
| // fork detection block | ||
| let mut best_block = max(io.chain().chain_info().best_block_number, self.highest_block.unwrap_or(0)); |
There was a problem hiding this comment.
isn't highest_block the highest block we've seen broadcasted? how will the check for sn - best_block > SNAPSHOT_RESTORE_THRESHOLD ever pass?
rphmeier
added
A5-grumble 🔥
arkpar
added
A4-gotissues 💥
arkpar
added
A0-pleasereview 🤓
rphmeier
reviewed
Nov 9, 2016
| .filter(|&(_, p)| p.is_allowed() && p.snapshot_number.map_or(false, |sn| | ||
| our_best_block < sn && (sn - our_best_block) > SNAPSHOT_RESTORE_THRESHOLD && | ||
| sn > fork_block && | ||
| self.highest_block.map_or(true, |highest| highest >= sn && (highest - sn) > SNAPSHOT_RESTORE_THRESHOLD) |
There was a problem hiding this comment.
won't this prevent the most recent snapshot from ever being used? This is basically requiring that whatever snapshot is chosen is at least 100k blocks old.
There was a problem hiding this comment.
is it a typo? < would make sense here
There was a problem hiding this comment.
I need to get some sleep
rphmeier
added
A5-grumble 🔥
arkpar
added
A0-pleasereview 🤓
rphmeier
added
A8-looksgood 🦄
arkpar
added a commit
that referenced
this pull request
Nov 9, 2016
* Additional snapshot sync checks * Proper checks * Proper highset block check
arkpar
added a commit
that referenced
this pull request
Nov 9, 2016
* Additional snapshot sync checks * Proper checks * Proper highset block check
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.