This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
fetch known code from the database during restoration #3377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously it kept all seen code in memory, leading to high memory usage by the end of state restoration
rphmeier
added
A0-pleasereview 🤓
|
js-tests fail :-S |
[ci:skip]
|
does a test hit this codepath? |
|
Haven't touched any JS here. I think that the |
|
Ok, test added. |
|
Think this one should be a B0-patch? |
gavofyork
added
B0-patch
A8-looksgood 🦄
rphmeier
force-pushed
the
missing-code-by-prefix
branch
from
1512043
to
18153b8
Compare
rphmeier
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously it kept all seen code in memory, leading to high memory usage by the end of state restoration.
Lowers memory usage by ~150MB when warp syncing.
Related to #3304