Real deleting accounts #3540
Real deleting accounts #3540
Conversation
gavofyork
commented
Nov 20, 2016
•
gavofyork
commented
- RPC
- Test for RPC
- parity.js binding
- UI integration
gavofyork
added
A0-pleasereview 🤓
|
Last two should be down to @jacogr |
|
Linked issue https://github.com/ethcore/parity/issues/3105 |
|
over to you, @jacogr . |
|
UI integration - https://youtu.be/4Ih7ITwbq-A @gavofyork It would be good if we could have the same for the |
jacogr
added
A0-pleasereview 🤓
gavofyork
added
A0-pleasereview 🤓
|
will do the address book deletion in a separate PR. |
| take_weak!(self.accounts) | ||
| .kill_account(&account, &password) | ||
| .map(|_| true) | ||
| .map_err(|e| errors::account("Could not fetch account info.", e)) |
There was a problem hiding this comment.
"Could not kill account?"
| let res = tester.io.handle_request_sync(&request); | ||
| assert_eq!(res, Some(response.into())); | ||
|
|
||
| let request = r#"{"jsonrpc": "2.0", "method": "parity_accountsInfo", "params": [], "id": 1}"#; |
There was a problem hiding this comment.
Could be just a check in tester.accounts, no?
There was a problem hiding this comment.
where is tester.accounts?
| onDeny={ this.closeDeleteDialog } | ||
| onConfirm={ this.onDeleteConfirmed }> | ||
| <div className={ styles.hero }> | ||
| Are you sure you want to remove permanently delete the following account? |
There was a problem hiding this comment.
"remove permanently delete"
| newError(new Error('Deletion failed.')); | ||
| } | ||
|
|
||
| this.closeDeleteDialog(); |
There was a problem hiding this comment.
Do we really want to close the dialog if there is an error?
| .catch((error) => { | ||
| console.error('onDeleteConfirmed', error); | ||
| newError(new Error(`Deletion failed: ${error.message}`)); | ||
| this.closeDeleteDialog(); |
There was a problem hiding this comment.
Do we really want to close the dialog if there is an error?
| static propTypes = { | ||
| account: PropTypes.object.isRequired, | ||
| onClose: PropTypes.func, | ||
| newError: PropTypes.func |
There was a problem hiding this comment.
Why the functions are not required?
Consider static defaultProps = { onClose: () => {}, newError: () => () }
tomusdrw
added
A5-grumble 🔥
|
grumbles addressed on my part |
jacogr
added
A0-pleasereview 🤓
gavofyork
added
A8-looksgood 🦄
