This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Splitting serialization of signTransaction and sendTransaction confirmation requests #3642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A0-pleasereview 🤓
tomusdrw
added
the
B7-releasenotes 📜
gavofyork
added
A8-looksgood 🦄
|
lgtm. @jacogr / @ngotchac / @derhuerst could you cast a swift eye over the JS? |
derhuerst
reviewed
Nov 28, 2016
| @@ -72,8 +72,8 @@ export default class SignerMiddleware { | |||
| }; | |||
|
|
|||
| // Sign request in-browser | |||
| if (wallet && payload.transaction) { | |||
| const { transaction } = payload; | |||
| if (wallet && (payload.sendTransaction || payload.signTransaction)) { | |||
There was a problem hiding this comment.
[tiny tiny grumble] Why not this?
const transaction = payload.sendTransaction || payload.signTransaction;
if (wallet && transaction) {There was a problem hiding this comment.
Good point :) Fixing.
derhuerst
reviewed
Nov 28, 2016
| @@ -58,8 +59,8 @@ export default class RequestFinished extends Component { | |||
| ); | |||
| } | |||
|
|
|||
| if (payload.transaction) { | |||
| const { transaction } = payload; | |||
| if (payload.sendTransaction || payload.signTransaction) { | |||
tomusdrw
added
A3-inprogress ⏳
tomusdrw
added
A0-pleasereview 🤓
jacogr
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3560
Breaks compatibility with Chrome Plugin (we should probably mention in Release notes that it's already deprecated)