This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Filter null transactions for display (not available on node) #3698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derhuerst
reviewed
Dec 1, 2016
| @@ -93,7 +93,7 @@ export default class Store { | |||
| Promise | |||
| .all(txhashes.map((txhash) => this._api.eth.getTransactionByHash(txhash))) | |||
| .then((_transactions) => { | |||
| const transactions = _transactions.filter((tx) => tx); | |||
| const transactions = _transactions.filter((tx) => tx) || []; | |||
There was a problem hiding this comment.
Array.prototype.filter always returns an Array.
There was a problem hiding this comment.
You are right, mistook myself for using .find there for a moment.
gavofyork
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the node is syncing and we try to find a non-existent (though valid) hash, the transaction can be null. Filter null retrieved transactions before attempting to add it to the list.