This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Use Webpack Aliases #3711
Merged
Use Webpack Aliases #3711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling adcd707 on ng-webpack-improv into ** on master**. |
jacogr
reviewed
Dec 3, 2016
| @@ -17,7 +17,7 @@ | |||
| import BigNumber from 'bignumber.js'; | |||
| import React, { Component, PropTypes } from 'react'; | |||
|
|
|||
| import { eip20 } from '../../../../contracts/abi'; | |||
| import { eip20 } from 'contracts/abi'; | |||
There was a problem hiding this comment.
I think I probably would have preferred a ~/contracts/abi - as is just makes it very clear which is the local modules. (As opposed to the current which could be an alias or a module)
jacogr
reviewed
Dec 3, 2016
| import * as abis from '../../contracts/abi'; | ||
| import builtins from '../../views/Dapps/builtin.json'; | ||
| import * as abis from 'contracts/abi'; | ||
| import builtins from 'views/Dapps/builtin.json'; |
jacogr
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few aliases has been added to Webpack :
~points to thesrcdir, so we don't have to write../../../../utilproviders,ui,views,contractsandmodalspoint to the right directoy