Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Unify proptypes in util/proptypes.js #3728

Merged
merged 2 commits into from
Dec 7, 2016
Merged

Unify proptypes in util/proptypes.js #3728

merged 2 commits into from
Dec 7, 2016

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Dec 6, 2016

  • combine all defined proptypes in util/proptypes.js
  • add new PropTypes as cherry-picked from WIP branches
  • change all existing references
  • make references consistent between nullable & nullableProptype

@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels Dec 6, 2016
@derhuerst
Copy link
Contributor

There are a few missing:

  • ui/ConfirmDialog/confirmDialog.js
  • ui/Container/container.js
  • ui/Container/Title/title.js
  • ui/Form/InputInline/inputInline.js
  • ui/Modal/modal.js
  • ui/Modal/Title/title.js

@derhuerst derhuerst added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Dec 6, 2016
@jacogr jacogr merged commit e2bb8ef into master Dec 7, 2016
@jacogr jacogr deleted the jg-proptypes branch December 7, 2016 12:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants