Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Add functionalities to multi-sig wallet #3729

Merged
merged 11 commits into from
Dec 7, 2016
Merged

Add functionalities to multi-sig wallet #3729

merged 11 commits into from
Dec 7, 2016

Conversation

ngotchac
Copy link
Contributor

@ngotchac ngotchac commented Dec 6, 2016

WIP for Multi-Sig Wallet #3282

  • Add transfer of tokens capabilities to Wallets
  • Now can watch an already deployed Wallet from its address (still needs some work, at least check if the Wallet is compatible)
  • Delete a Wallet
  • Fix Transfer modal to separate balance from sender and account (for Wallet transfers, sender pays gas, but the value would be subtracted from the Wallet balance)

@ngotchac ngotchac added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels Dec 6, 2016
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling b43b361 on ng-multisig-tokens into ** on master**.


<TypedInput
label='wallet day limit'
hint='number of days to wait for other owners confirmation'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the hint correct?

@@ -16,26 +16,29 @@

import { observable, computed, action, transaction } from 'mobx';

import { ERRORS, validateUint, validateAddress, validateName } from '../../util/validation';
import { validateUint, validateAddress, validateName } from '../../util/validation';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~/util plus move down to the other util import

import ContentSend from 'material-ui/svg-icons/content/send';

import nullableProptype from '~/util/nullable-proptype';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just be aware of this PR - https://github.com/ethcore/parity/pull/3728

@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Dec 7, 2016
@jacogr jacogr merged commit 8dbd568 into master Dec 7, 2016
@jacogr jacogr deleted the ng-multisig-tokens branch December 7, 2016 11:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants