This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add functionalities to multi-sig wallet #3729
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes Unknown when pulling b43b361 on ng-multisig-tokens into ** on master**. |
jacogr
reviewed
Dec 6, 2016
|
||
<TypedInput | ||
label='wallet day limit' | ||
hint='number of days to wait for other owners confirmation' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the hint correct?
jacogr
reviewed
Dec 6, 2016
@@ -16,26 +16,29 @@ | |||
|
|||
import { observable, computed, action, transaction } from 'mobx'; | |||
|
|||
import { ERRORS, validateUint, validateAddress, validateName } from '../../util/validation'; | |||
import { validateUint, validateAddress, validateName } from '../../util/validation'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
~/util
plus move down to the other util import
jacogr
reviewed
Dec 6, 2016
import ContentSend from 'material-ui/svg-icons/content/send'; | ||
|
||
import nullableProptype from '~/util/nullable-proptype'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just be aware of this PR - https://github.com/ethcore/parity/pull/3728
jacogr
added
A8-looksgood 🦄
Pull request is reviewed well.
and removed
A0-pleasereview 🤓
Pull request needs code review.
labels
Dec 7, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP for Multi-Sig Wallet #3282