This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
fix verification stores #3864
Merged
fix verification stores #3864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacogr
reviewed
Dec 15, 2016
| @@ -54,7 +54,7 @@ export default class EmailVerificationStore extends VerificationStore { | |||
| } | |||
|
|
|||
| constructor (api, account, isTestnet) { | |||
| super(api, EmailVerificationABI, 'emailverification3', account, isTestnet); | |||
| super(api, EmailVerificationABI, 4, account, isTestnet); | |||
There was a problem hiding this comment.
Not sure I 100% like the magic numbers (would probably make more sense as a constant to at least specify intent, especially in 3 months from now)
There was a problem hiding this comment.
fully agree, that's why i had changed it to string in the first place. constants is a good solution i think.
jacogr
added
A6-mustntgrumble 💦
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gavofyork please check if it works.