This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Naive light client synchronization #3892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkpar
added
A7-looksgoodcantmerge 🙄
|
ethcore/res/ethereum/tests needs reverting |
rphmeier
added
A8-looksgood 🦄
|
Changes Unknown when pulling d0194f3 on lightsync into ** on master**. |
|
Changes Unknown when pulling 0688ccb on lightsync into ** on master**. |
NikVolf
reviewed
Dec 27, 2016
| if number == 1 { | ||
| let g_view = HeaderView::new(&self.genesis_header); | ||
| g_view.difficulty() | ||
| } else { |
There was a problem hiding this comment.
else {
try!(candidates.get(&(number - 1))
.and_then(|entry| entry.candidates.iter().find(|c| c.hash == parent_hash))
.map(|c| c.total_difficulty)
.ok_or(BlockError::UnknownParent(parent_hash)))
}?
NikVolf
reviewed
Dec 27, 2016
| pub fn genesis_hash(&self) -> H256 { | ||
| use util::Hashable; | ||
|
|
||
| self.genesis_header.sha3() |
There was a problem hiding this comment.
one-liner
::util::Hashable::sha3(&self.genesis_header)
?
|
Changes Unknown when pulling 55dbfbf on lightsync into ** on master**. |
|
Given that 1.5 has been delayed a bit, it might make sense to remove the CLI option for now and merge this into master afterwards. I have a few pending PRs which build upon it but I haven't made yet in anticipation of the merge. |
rphmeier
removed
the
A1-onice 🌨
|
(CLI removed) |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work was getting pretty massive so I've decided to cut it off here for now and leave further improvements/tests to future PRs.
Please review but don't merge until 1.5 is released.