This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Display 0x00..00 as null #3950
Merged
Display 0x00..00 as null #3950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacogr
added
A0-pleasereview 🤓
jacogr
added
A0-pleasereview 🤓
derhuerst
reviewed
Dec 22, 2016
| @@ -62,6 +63,7 @@ class InputAddress extends Component { | |||
| classes.push(!icon ? styles.inputEmpty : styles.input); | |||
|
|
|||
| const containerClasses = [ styles.container ]; | |||
| const nullName = new BigNumber(value).eq(0) ? 'null' : null; | |||
There was a problem hiding this comment.
I'd prefer isNull or isZero here.
derhuerst
reviewed
Dec 22, 2016
| ); | ||
| } else if (new BigNumber(address).eq(0)) { | ||
| return ( | ||
| <div |
There was a problem hiding this comment.
I'd consider something more helpful here, e.g. material-ui/svg-icons/content/clear. cc @gavofyork #3908
derhuerst
added
A6-mustntgrumble 💦
jacogr
added a commit
that referenced
this pull request
Jan 2, 2017
Merged
jacogr
added a commit
that referenced
this pull request
Jan 5, 2017
* Update blockStatus & test results * IdentityIcon rendering tests for #3950 * Update IdentityName with external messages * Expand to cover basic layout sections * ConfirmDialog rendering tests * TxHash expansion & tests * Cleanup ui/*.spec.js PropType warnings * Use react-intl plural for confirmation/confirmations (verified manually)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display for 0x0000...0000 address
null(unless in addressbook)