-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Small UI fixes #3966
Small UI fixes #3966
Conversation
jacogr
commented
Dec 24, 2016
•
edited
Loading
edited
- Actually retrieve saved dapp visibility from storage (previously refreshing the page lost the visible apps, storage never taken into account)
- Align SVG address icons on MethodDecoding (previous these were displayed too low for null & contract addresses - also Closes https://github.com/ethcore/parity/issues/3954)
- Improve isNullAddress check (actual full value)
Using |
Made isNullAddress explicit & more robust (right PR to add it in, missed that bug in my checking) |
The only grumble is that in the Add Address Modal, when you enter |
Can add it, it just displays 'null' as the name. Made it so it doesn't display the name on input, only when queried. |
@@ -69,7 +69,7 @@ class InputAddress extends Component { | |||
classes.push(!icon ? styles.inputEmpty : styles.input); | |||
|
|||
const containerClasses = [ styles.container ]; | |||
const nullName = value && new BigNumber(value).eq(0) ? 'null' : null; | |||
const nullName = readOnly && isNullAddress(value) ? 'null' : null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to check disabled
as well (it's the one used in contracts)