This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Account view updates #4008
Merged
Account view updates #4008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacogr
added
A3-inprogress ⏳
jacogr
added
A0-pleasereview 🤓
ngotchac
reviewed
Jan 4, 2017
| <Certifications | ||
| account={ account.address } | ||
| /> | ||
| <Certifications address={ account.address } /> |
There was a problem hiding this comment.
Could use address there, right?
| this.setAddress(props.address); | ||
| this.setTest(props.isTest); | ||
|
|
||
| // TODO: When tracing is enabled again, adjust to actually set |
|
|
||
| this.setLoading(true); | ||
|
|
||
| // TODO: When supporting other chains (eg. ETC). call to be made to other endpoints |
There was a problem hiding this comment.
Couldn't we already use the chain ID ? Pass it to the Etherscan API call, which right now would only switch from main to test networks, but could potentially make the right transaction fetching call.
Like this we would use the chain ID instead of isTest
There was a problem hiding this comment.
Agreed. Didn't want to do it here since it may be one of those exploding tasks that turns into changes in 50+ files - however would like to start using netChain instead of isTest as soon as possible.
ngotchac
added
A6-mustntgrumble 💦
|
Tiny comments, but looks good overall. Cannot merge though |
Fix merge conflicts in icons
ngotchac
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not critical for 1.5, could wait if need be.