Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Don't slice non-existent tags #4000

Merged
merged 1 commit into from
Dec 29, 2016
Merged

Don't slice non-existent tags #4000

merged 1 commit into from
Dec 29, 2016

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Dec 29, 2016

@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels Dec 29, 2016
@ngotchac ngotchac added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Dec 29, 2016
@gavofyork gavofyork merged commit 37c607d into master Dec 29, 2016
@gavofyork gavofyork deleted the jg-fix-empty-tags branch December 29, 2016 20:01
jacogr added a commit that referenced this pull request Jan 2, 2017
@jacogr jacogr mentioned this pull request Jan 2, 2017
jacogr added a commit that referenced this pull request Jan 5, 2017
* Fix null account render issue, add tests

* Add tests for #3999 fix (merged in #4000)

* Only include sinon-as-promised globally for mocha

* Move transactions state into tested store

* Add esjify for mocha + ejs (cherry-picked)

* Extract store state into store, test it

* Use address (as per PR comments)

* Fix failing test after master merge
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants