This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fix balances update #4077
Merged
Fix balances update #4077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling cfafa65 on ng-fix-balances-update into ** on master**. |
jacogr
added
A8-looksgood 🦄
|
Just a general comment on this one - we need a couple of tests here, we've had some comebacks and it is quite involved. (Just need some re-assurance.) As-is, does look fine though. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Balances weren't fetched properly. The visible accounts was always empty, and we were fetching all the accounts at each block, and not the user accounts + the visible accounts (user accounts at each block necessary for transaction notification).
Plus the number of outgoing transaction on an Account page wasn't working.