This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Use binary chop to estimate gas accurately #4100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
A3-inprogress ⏳
rphmeier
reviewed
Jan 10, 2017
| /// Find transition point between `lower` and `upper` where `cond` changes from `false` to `true`. | ||
| /// Returns the lowest value between `lower` and `upper` for which `cond` returns true. | ||
| /// We assert: `cond(lower) = false`, `cond(upper) = true` | ||
| pub fn binary_chop<F>(mut lower: U256, mut upper: U256, mut cond: F) -> U256 where F: FnMut(U256) -> bool { |
There was a problem hiding this comment.
Does this really belong in client? Should either be in a utility file or an inline function within estimate_gas if that's truly the only place it's useful.
|
Changes Unknown when pulling 3948511 on estimate-gas into ** on master**. |
|
Changes Unknown when pulling 3948511 on estimate-gas into ** on master**. |
arkpar
added
A0-pleasereview 🤓
arkpar
reviewed
Jan 10, 2017
| @@ -848,7 +848,7 @@ impl BlockChainClient for Client { | |||
| difficulty: header.difficulty(), | |||
| last_hashes: last_hashes, | |||
| gas_used: U256::zero(), | |||
| gas_limit: U256::max_value(), | |||
| gas_limit: header.gas_limit(), | |||
There was a problem hiding this comment.
One of the use cases for gas estimation is to see how much over the block gas limit it is. geth sets the hard estimation limit to 50M
arkpar
added
A5-grumble 🔥
|
Changes Unknown when pulling d3110b8 on estimate-gas into ** on master**. |
gavofyork
added
A0-pleasereview 🤓
arkpar
added
A8-looksgood 🦄
|
build failure looks spurious. maybe we should disable by default the |
arkpar
added
A7-looksgoodtestsfail 🤖
arkpar
added
B0-patch
A8-looksgood 🦄
|
Changes Unknown when pulling 3c7b377 on estimate-gas into ** on master**. |
|
Changes Unknown when pulling 3c7b377 on estimate-gas into ** on master**. |
arkpar
pushed a commit
that referenced
this pull request
Jan 10, 2017
* Initial sketch. * Building. * Fix a few things. * Fix issue, add tracing. * Address grumbles * Raise upper limit if needed * Fix test.
Merged
gavofyork
pushed a commit
that referenced
this pull request
Jan 11, 2017
* Ignore get_price_info test by default. (#4112) * Auto-detect hex encoded bytes in sha3 (#4108) * Auto-detect hex encoded bytes in sha3 * Using types/isHex * Removing unused imports * Use binary chop to estimate gas accurately (#4100) * Initial sketch. * Building. * Fix a few things. * Fix issue, add tracing. * Address grumbles * Raise upper limit if needed * Fix test. * Fixing decoding API with signatures in names (#4125) * Fix call/estimate_gas (#4121) * Return 0 instead of error with out of gas on estimate_gas * Fix stuff up.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a binary chop algorithm to determine an accurate idea of how much gas a call/transaction needs to succeed.
Could do with a bit of DRYing up to avoid code duplication between client and miner - that might wait for a follow up refactoring PR, though.
Could also do with a slightly better error when the amount of gas required exceeds the block gas limit.
Could also be optimised by avoiding the costly tx tracing and instead passing the exception status of the outer call back from
Executive::transact.Closes #3930, #3749, #2061