Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Poll for upgrades as part of global status (long) #4197

Merged
merged 2 commits into from
Jan 18, 2017
Merged

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Jan 18, 2017

Closes https://github.com/ethcore/parity/issues/4192

@ngotchac Could I please have your eyes on this.

@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels Jan 18, 2017
@ngotchac
Copy link
Contributor

Looks good, however CHECK_INTERVAL is no more. It could be re-introduced by just using a throttle function (eg. from lodash) that will get called every minute or so.

@ngotchac ngotchac added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. labels Jan 18, 2017
@gavofyork gavofyork merged commit c1ce65c into master Jan 18, 2017
@gavofyork gavofyork deleted the jg-update-polling branch January 18, 2017 11:44
arkpar pushed a commit that referenced this pull request Jan 18, 2017
* Poll for upgrades as part of global status (long)

* Fix path
gavofyork pushed a commit that referenced this pull request Jan 18, 2017
* Minor typo to ensure it updates only when synced. (#4188)

* Updater fixes (#4196)

* Minor typo to ensure it updates only when synced.

* Fix deadlock.

* Skip unneeded arg in making list.

* Allow auto-restart even when not running an update.

* Fix trace.

* Update update info on each loop.

* Fix build.

* Shutdown all sockets

* Remove superfluous use.

* Poll for upgrades as part of global status (long) (#4197)

* Poll for upgrades as part of global status (long)

* Fix path

* Prevent duplicate incoming connections (#4180)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants