This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Updater fixes #4196
Merged
Updater fixes #4196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkpar
added
A0-pleasereview 🤓
rphmeier
reviewed
Jan 17, 2017
| @@ -18,6 +18,7 @@ use std::sync::{Arc, Weak}; | |||
| use std::fs; | |||
| use std::io::Write; | |||
| use std::path::{PathBuf}; | |||
| use std::mem::drop; | |||
|
The windows-based cleanup here seems kind of hacky. It ought to be possible to configure it so parity-as-a-node never runs in the same process as parity-as-a-hypervisor, even when running |
gavofyork
added
A8-looksgood 🦄
arkpar
added a commit
that referenced
this pull request
Jan 18, 2017
* Minor typo to ensure it updates only when synced. * Fix deadlock. * Skip unneeded arg in making list. * Allow auto-restart even when not running an update. * Fix trace. * Update update info on each loop. * Fix build. * Shutdown all sockets * Remove superfluous use.
gavofyork
pushed a commit
that referenced
this pull request
Jan 18, 2017
* Minor typo to ensure it updates only when synced. (#4188) * Updater fixes (#4196) * Minor typo to ensure it updates only when synced. * Fix deadlock. * Skip unneeded arg in making list. * Allow auto-restart even when not running an update. * Fix trace. * Update update info on each loop. * Fix build. * Shutdown all sockets * Remove superfluous use. * Poll for upgrades as part of global status (long) (#4197) * Poll for upgrades as part of global status (long) * Fix path * Prevent duplicate incoming connections (#4180)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.