Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Add ability to configure Secure API #4922

Merged
merged 1 commit into from
Mar 15, 2017
Merged

Add ability to configure Secure API #4922

merged 1 commit into from
Mar 15, 2017

Conversation

ngotchac
Copy link
Contributor

@ngotchac ngotchac commented Mar 15, 2017

@ngotchac ngotchac added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels Mar 15, 2017
@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 15, 2017
@jacogr
Copy link
Contributor

jacogr commented Mar 15, 2017

Probably want to backport this as well since if we have the check in the extension, we just want to minimise the number of "configuring it via private" out there. Non-invasive as well.

@gavofyork gavofyork merged commit ba07c32 into master Mar 15, 2017
@gavofyork gavofyork deleted the ng-configure-api branch March 15, 2017 18:15
@jacogr jacogr mentioned this pull request Mar 22, 2017
arkpar pushed a commit that referenced this pull request Mar 22, 2017
* [ci skip] js-precompiled 20170314-121823

* Attach hardware wallets already in addressbook (#4912)

* Attach hardware wallets already in addressbook

* Only set values changed

* Add Vaults logic to First Run (#4894) (#4914)

* Add ability to configure Secure API (for #4885) (#4922)

* Add z-index to small modals as well (#4923)

* eth_sign where account === undefined (#4964)

* Update for case where account === undefined

* Update tests to not mask account === undefined

* default account = {} where undefined (thanks @tomusdrw)

* Fix Password Dialog forms style issue (#4968)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants