This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Better memory management #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkpar
added
the
A3-inprogress ⏳
| impl Default for BlockQueueConfig { | ||
| fn default() -> Self { | ||
| BlockQueueConfig { | ||
| max_queue_size: 30000, |
There was a problem hiding this comment.
No test proof that this options are actually working
| @@ -220,33 +238,7 @@ const COLLECTION_QUEUE_SIZE: usize = 8; | |||
|
|
|||
| impl BlockChain { | |||
| /// Create new instance of blockchain from given Genesis | |||
| /// | |||
There was a problem hiding this comment.
BlockChain is no longer part of the public crate interface
arkpar
added
A0-pleasereview 🤓
| @@ -58,6 +58,8 @@ pub struct Spec { | |||
|
|
|||
| /// Known nodes on the network in enode format. | |||
| pub nodes: Vec<String>, | |||
| /// Network ID | |||
| pub network_id: U256, | |||
There was a problem hiding this comment.
where does this come from? should it be part of this PR?
There was a problem hiding this comment.
Well, I've added a number of configuration options in this PR, and that's one of them.
gavofyork
added
A6-mustntgrumble 💦
arkpar
added
A0-pleasereview 🤓
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.