This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested with Oprah badge on Kovan - Address: 0x057Be351016DB801529bb19a89e6F72E7F7FB4aa ABI:
|
Bug Repro:
Expected: The badges should be on the correct accounts (Main and AAA) Actual: The badges are on the accounts with the same index in the array Edit: I think this bug is the same as #7337, but in that case, all the badges were on the 2nd row. |
jacogr
added
A3-inprogress ⏳
Pull request is in progress. No review needed at this stage.
and removed
A0-pleasereview 🤓
Pull request needs code review.
labels
Jan 4, 2018
jacogr
added
A0-pleasereview 🤓
Pull request needs code review.
and removed
A3-inprogress ⏳
Pull request is in progress. No review needed at this stage.
labels
Jan 4, 2018
amaury1093
approved these changes
Jan 4, 2018
Yes, the latest commit fixed the bug for me. Everything working fine on my side. |
amaury1093
added
A8-looksgood 🦄
Pull request is reviewed well.
and removed
A0-pleasereview 🤓
Pull request needs code review.
labels
Jan 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7337
This one is weird, changes made should not have affected the outcome, but made it appear.