Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Cleanup certifications #7454

Merged
merged 7 commits into from Jan 5, 2018
Merged

Cleanup certifications #7454

merged 7 commits into from Jan 5, 2018

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Jan 4, 2018

Closes #7337

This one is weird, changes made should not have affected the outcome, but made it appear.

parity 2018-01-04 13-28-58

@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels Jan 4, 2018
@jacogr
Copy link
Contributor Author

jacogr commented Jan 4, 2018

Tested with Oprah badge on Kovan -

Address:

0x057Be351016DB801529bb19a89e6F72E7F7FB4aa

ABI:

[
  {
    "constant": false,
    "inputs": [
      {
        "name": "_new",
        "type": "address"
      }
    ],
    "name": "setOwner",
    "outputs": [],
    "payable": false,
    "stateMutability": "nonpayable",
    "type": "function"
  },
  {
    "constant": true,
    "inputs": [
      {
        "name": "_who",
        "type": "address"
      },
      {
        "name": "_field",
        "type": "string"
      }
    ],
    "name": "getData",
    "outputs": [
      {
        "name": "",
        "type": "bytes32"
      }
    ],
    "payable": false,
    "stateMutability": "view",
    "type": "function"
  },
  {
    "constant": true,
    "inputs": [
      {
        "name": "_who",
        "type": "address"
      },
      {
        "name": "_field",
        "type": "string"
      }
    ],
    "name": "getAddress",
    "outputs": [
      {
        "name": "",
        "type": "address"
      }
    ],
    "payable": false,
    "stateMutability": "view",
    "type": "function"
  },
  {
    "constant": false,
    "inputs": [],
    "name": "certify",
    "outputs": [],
    "payable": false,
    "stateMutability": "nonpayable",
    "type": "function"
  },
  {
    "constant": true,
    "inputs": [],
    "name": "owner",
    "outputs": [
      {
        "name": "",
        "type": "address"
      }
    ],
    "payable": false,
    "stateMutability": "view",
    "type": "function"
  },
  {
    "constant": false,
    "inputs": [],
    "name": "revoke",
    "outputs": [],
    "payable": false,
    "stateMutability": "nonpayable",
    "type": "function"
  },
  {
    "constant": true,
    "inputs": [
      {
        "name": "_who",
        "type": "address"
      },
      {
        "name": "_field",
        "type": "string"
      }
    ],
    "name": "getUint",
    "outputs": [
      {
        "name": "",
        "type": "uint256"
      }
    ],
    "payable": false,
    "stateMutability": "view",
    "type": "function"
  },
  {
    "constant": true,
    "inputs": [
      {
        "name": "_who",
        "type": "address"
      }
    ],
    "name": "certified",
    "outputs": [
      {
        "name": "",
        "type": "bool"
      }
    ],
    "payable": false,
    "stateMutability": "view",
    "type": "function"
  },
  {
    "constant": true,
    "inputs": [
      {
        "name": "_who",
        "type": "address"
      },
      {
        "name": "_field",
        "type": "string"
      }
    ],
    "name": "get",
    "outputs": [
      {
        "name": "",
        "type": "bytes32"
      }
    ],
    "payable": false,
    "stateMutability": "view",
    "type": "function"
  },
  {
    "anonymous": false,
    "inputs": [
      {
        "indexed": true,
        "name": "who",
        "type": "address"
      }
    ],
    "name": "Confirmed",
    "type": "event"
  },
  {
    "anonymous": false,
    "inputs": [
      {
        "indexed": true,
        "name": "who",
        "type": "address"
      }
    ],
    "name": "Revoked",
    "type": "event"
  },
  {
    "anonymous": false,
    "inputs": [
      {
        "indexed": true,
        "name": "old",
        "type": "address"
      },
      {
        "indexed": true,
        "name": "current",
        "type": "address"
      }
    ],
    "name": "NewOwner",
    "type": "event"
  }
]

@5chdn 5chdn added this to the 1.9 milestone Jan 4, 2018
@amaury1093
Copy link
Contributor

amaury1093 commented Jan 4, 2018

Bug Repro:
You need to have at least 1 account that's not certified.

  • Go to accounts page. I see the badge on the 1st row (can't repro original issue). You should see this:
    screen shot 2018-01-04 at 2 44 18 pm
  • Change the filter. I filtered by Name

Expected: The badges should be on the correct accounts (Main and AAA)

Actual: The badges are on the accounts with the same index in the array
screen shot 2018-01-04 at 2 49 38 pm

Edit: I think this bug is the same as #7337, but in that case, all the badges were on the 2nd row.

@jacogr jacogr added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jan 4, 2018
@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Jan 4, 2018
@amaury1093
Copy link
Contributor

Yes, the latest commit fixed the bug for me. Everything working fine on my side.

@amaury1093 amaury1093 added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jan 4, 2018
@jacogr jacogr merged commit 71da3af into master Jan 5, 2018
@jacogr jacogr deleted the jg-badge-first-row branch January 5, 2018 12:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants