Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust doc user journey: CLI #17

Closed
kianenigma opened this issue May 15, 2023 · 4 comments
Closed

Rust doc user journey: CLI #17

kianenigma opened this issue May 15, 2023 · 4 comments
Labels
generalist Issue requires technical knowledge, but not deeply. infra issue does not require specific knowledge of the content, and is mainly about the system.

Comments

@kianenigma
Copy link
Collaborator

I think this is a great example of a page that should have been entirely documented in rust-docs: it is almost entirely copy-pasted, and extremely hard to maintain: https://docs.substrate.io/reference/command-line-tools/node-template/

We should focus on the documentation of the crate https://paritytech.github.io/substrate/master/sc_cli/index.html and improve it such that this page can act as the single source of truth for CLI args.

This crate should be linked in #11.

@kianenigma kianenigma added generalist Issue requires technical knowledge, but not deeply. infra issue does not require specific knowledge of the content, and is mainly about the system. labels May 15, 2023
@CrackTheCode016
Copy link
Collaborator

As a note (and this is probably already obvious), a lot of pallets, in general, contain super valuable docs ranging from the intention of the pallet to individual extrinsics.

Not sure off the top of my head, but grabbing that as a part of the docs wouldn't be a terrible idea (with added context in some cases)

@kianenigma
Copy link
Collaborator Author

All such docs are accessible in http://paritytech.github.io/ and #9, is that what you mean?

@kianenigma
Copy link
Collaborator Author

I tried to take a stab at this in paritytech/substrate#14581, but the experience is still pretty rubbish.

@kianenigma kianenigma changed the title improve the experience when trying to find the substrate/polkadot CLI options via rust-docs. Rust doc user journey: CLI Jul 22, 2023
@kianenigma
Copy link
Collaborator Author

It seems like in each chain, we expect to run a struct Cli of some sort, with a run and subcommands fields.

The run command gets the same set of arguments in each chain, defined here: https://paritytech.github.io/substrate/master/sc_cli/commands/struct.RunCmd.html
the subcommand is different per chain, such as:

https://paritytech.github.io/substrate/master/node_template/cli/enum.Subcommand.html
https://paritytech.github.io/substrate/master/node_cli/enum.Subcommand.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generalist Issue requires technical knowledge, but not deeply. infra issue does not require specific knowledge of the content, and is mainly about the system.
Projects
None yet
Development

No branches or pull requests

2 participants