-
Notifications
You must be signed in to change notification settings - Fork 579
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
1e87878
commit 842ac03
Showing
2 changed files
with
81 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
#!/usr/bin/env python3 | ||
|
||
# A script that checks each workspace crate individually. | ||
# It's relevant to check workspace crates individually because otherwise their compilation problems | ||
# due to feature misconfigurations won't be caught, as exemplified by | ||
# https://github.com/paritytech/substrate/issues/12705 | ||
# | ||
# `check-each-crate.py target_group groups_total` | ||
# | ||
# - `target_group`: Integer starting from 1, the group this script should execute. | ||
# - `groups_total`: Integer starting from 1, total number of groups. | ||
|
||
import subprocess, sys | ||
|
||
# Get all crates | ||
output = subprocess.check_output(["cargo", "tree", "--locked", "--workspace", "--depth", "0", "--prefix", "none"]) | ||
|
||
# Convert the output into a proper list | ||
crates = [] | ||
for line in output.splitlines(): | ||
if line != b"": | ||
line = line.decode('utf8').split(" ") | ||
crate_name = line[0] | ||
# The crate path is always the last element in the line. | ||
crate_path = line[len(line) - 1].replace("(", "").replace(")", "") | ||
crates.append((crate_name, crate_path)) | ||
|
||
# Make the list unique and sorted | ||
crates = list(set(crates)) | ||
crates.sort() | ||
|
||
target_group = int(sys.argv[1]) - 1 | ||
groups_total = int(sys.argv[2]) | ||
|
||
if len(crates) == 0: | ||
print("No crates detected!", file=sys.stderr) | ||
sys.exit(1) | ||
|
||
print(f"Total crates: {len(crates)}", file=sys.stderr) | ||
|
||
crates_per_group = len(crates) // groups_total | ||
|
||
# If this is the last runner, we need to take care of crates | ||
# after the group that we lost because of the integer division. | ||
if target_group + 1 == groups_total: | ||
overflow_crates = len(crates) % groups_total | ||
else: | ||
overflow_crates = 0 | ||
|
||
print(f"Crates per group: {crates_per_group}", file=sys.stderr) | ||
|
||
# Check each crate | ||
for i in range(0, crates_per_group + overflow_crates): | ||
crate = crates_per_group * target_group + i | ||
|
||
print(f"Checking {crates[crate][0]}", file=sys.stderr) | ||
|
||
res = subprocess.run(["cargo", "check", "--locked"], cwd = crates[crate][1]) | ||
|
||
if res.returncode != 0: | ||
sys.exit(1) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
name: Check each crate in parallel | ||
|
||
on: | ||
push: | ||
branches: | ||
#TODO: Update to master | ||
- oleg/ci_cd/907 | ||
pull_request: | ||
types: [opened, synchronize, reopened, ready_for_review] | ||
merge_group: | ||
|
||
jobs: | ||
check_each_crate: | ||
strategy: | ||
matrix: | ||
group: [1, 2, 3, 4, 5, 6] | ||
runs-on: macos-latest | ||
steps: | ||
- name: Cargo check crates | ||
run: .github/scripts/common/check-each-crate.py ${{ matrix.group }} 6 |