Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scheduler: an overweight task removed silently #195

Open
2 tasks done
muharem opened this issue Mar 31, 2023 · 1 comment
Open
2 tasks done

Scheduler: an overweight task removed silently #195

muharem opened this issue Mar 31, 2023 · 1 comment
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I2-bug The node fails to follow expected behavior. T1-FRAME This PR/Issue is related to core FRAME, the framework.

Comments

@muharem
Copy link
Contributor

muharem commented Mar 31, 2023 •
edited

Is there an existing issue?

  • I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • This is not a support question.

Description of bug

A task which does not passes this weight check will be removed silently.

https://github.com/paritytech/substrate/blob/a7bc9c2a8c0a14fd6033de1f972a11a2b3dbb73a/frame/scheduler/src/lib.rs#L1014

Steps to reproduce

Schedule a task with a big len, to not pass that check.
The task wont be postponed even if its not a first task and removed silently with no errors

mentor: @muharem
@muharem muharem changed the title Scheduler: first overweight task removed silently Scheduler: an overweight task removed silently Mar 31, 2023
@bkchr
Copy link
Member

bkchr commented Apr 1, 2023

Yeah, we should only drop the task when the weight is > 9/10 of max block weight.

@juangirini juangirini transferred this issue from paritytech/substrate Aug 24, 2023
@the-right-joyce the-right-joyce added T1-FRAME This PR/Issue is related to core FRAME, the framework. and removed T1-runtime labels Aug 25, 2023
@muharem muharem added C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D1-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase. I2-bug The node fails to follow expected behavior. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. and removed D1-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase. labels Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I2-bug The node fails to follow expected behavior. T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
Runtime / FRAME
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
4 participants
@juangirini @bkchr @muharem @the-right-joyce