Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More specific errors for decrease_balance #2240

Open
liamaharon opened this issue Nov 9, 2023 · 2 comments
Open

More specific errors for decrease_balance #2240

liamaharon opened this issue Nov 9, 2023 · 2 comments
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I5-enhancement An additional feature request. T1-FRAME This PR/Issue is related to core FRAME, the framework.

Comments

@liamaharon
Copy link
Member 

          should we have an issue for more specific errors for `decrease_balance`?

Originally posted by @muharem in #1296 (comment)

Currently decrease_balance errors don't differentiate between failing due to ED or frozen constraints. Could improve the API by emitting a different error, depending on why it failed.
@liamaharon liamaharon added T1-FRAME This PR/Issue is related to core FRAME, the framework. C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. labels Nov 9, 2023
@ggwpez ggwpez added I5-enhancement An additional feature request. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. labels Feb 5, 2024
@asoliman92
Copy link

Is this still available? I can take it if so.

@chungquantin chungquantin mentioned this issue Mar 17, 2024
Open
1 task
@chungquantin
Copy link
Contributor

@liamaharon I have created a PR to work on this issue. Please give a check and let me know if there is another case need to be covered.

bkontur pushed a commit that referenced this issue May 15, 2024
@svyatonik @bkontur
Fix clippy (#2240)
0a56c0d 
* update async-trait to 0.1.69

* more clippy fixes
bkontur pushed a commit that referenced this issue May 16, 2024
@svyatonik @bkontur
Fix clippy (#2240)
81fb605 
* update async-trait to 0.1.69

* more clippy fixes
bkontur pushed a commit that referenced this issue May 17, 2024
@svyatonik @bkontur
Fix clippy (#2240)
13b071e 
* update async-trait to 0.1.69

* more clippy fixes
bkontur pushed a commit that referenced this issue May 17, 2024
@svyatonik @bkontur
Fix clippy (#2240)
dc73ac9 
* update async-trait to 0.1.69

* more clippy fixes
bkontur pushed a commit that referenced this issue May 17, 2024
@svyatonik @bkontur
Fix clippy (#2240)
f529231 
* update async-trait to 0.1.69

* more clippy fixes
bkontur pushed a commit that referenced this issue May 20, 2024
@svyatonik @bkontur
Fix clippy (#2240)
6299b1f 
* update async-trait to 0.1.69

* more clippy fixes
bkontur pushed a commit that referenced this issue May 21, 2024
@svyatonik @bkontur
Fix clippy (#2240)
47a7f20 
* update async-trait to 0.1.69

* more clippy fixes
bkontur pushed a commit that referenced this issue May 22, 2024
@svyatonik @bkontur
Fix clippy (#2240)
9f7eba5 
* update async-trait to 0.1.69

* more clippy fixes
bkontur pushed a commit that referenced this issue May 23, 2024
@svyatonik @bkontur
Fix clippy (#2240)
9bb8e20 
* update async-trait to 0.1.69

* more clippy fixes
bkontur pushed a commit that referenced this issue May 30, 2024
@svyatonik @bkontur
Fix clippy (#2240)
441be0b 
* update async-trait to 0.1.69

* more clippy fixes
bkontur pushed a commit that referenced this issue Jun 4, 2024
@svyatonik @bkontur
Fix clippy (#2240)
9e0698f 
* update async-trait to 0.1.69

* more clippy fixes
bkontur pushed a commit that referenced this issue Jun 5, 2024
@svyatonik @bkontur
Fix clippy (#2240)
25c25a7 
* update async-trait to 0.1.69

* more clippy fixes
bkontur pushed a commit that referenced this issue Jun 7, 2024
@svyatonik @bkontur
Fix clippy (#2240)
8bb3d1d 
* update async-trait to 0.1.69

* more clippy fixes
bkontur pushed a commit that referenced this issue Jun 7, 2024
@svyatonik @bkontur
Fix clippy (#2240)
ac9c870 
* update async-trait to 0.1.69

* more clippy fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I5-enhancement An additional feature request. T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@asoliman92 @ggwpez @liamaharon @chungquantin