Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XCM] don't ignore errors #2408

Open
xlc opened this issue Nov 20, 2023 · 3 comments
Open

[XCM] don't ignore errors #2408

xlc opened this issue Nov 20, 2023 · 3 comments
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I4-refactor Code needs refactoring. T6-XCM This PR/Issue is related to XCM.

Comments

@xlc
Copy link
Contributor

xlc commented Nov 20, 2023 •
edited 

          someone should make a rule to disallow ignoring errors

Originally posted by @xlc in #2405 (comment)

Need to make sure every .map_err(|_| are justified with good reasons.
@bkchr
Copy link
Member

bkchr commented Nov 20, 2023

map_err is not ignoring the error, it just maps it... as the name is already hinting.

@xlc
Copy link
Contributor Author

xlc commented Nov 20, 2023 •
edited

but |_| is ignoring it and it looks like a sad face

@ggwpez
Copy link
Member

ggwpez commented Mar 13, 2024

Should probably still be logged to ease debuggability.

@ggwpez ggwpez added C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. I4-refactor Code needs refactoring. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. labels Mar 13, 2024
@ggwpez ggwpez changed the title don't ignore errors [XCM] don't ignore errors Mar 13, 2024
@franciscoaguirre franciscoaguirre added the T6-XCM This PR/Issue is related to XCM. label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I4-refactor Code needs refactoring. T6-XCM This PR/Issue is related to XCM.
Projects
Parity Roadmap
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
4 participants
@xlc @franciscoaguirre @bkchr @ggwpez