Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FRAME Benchmarking CLI Flag for BenchmarkError Behavior #295

Open
shawntabrizi opened this issue Nov 30, 2021 · 2 comments
Open

FRAME Benchmarking CLI Flag for BenchmarkError Behavior #295

shawntabrizi opened this issue Nov 30, 2021 · 2 comments
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. T1-FRAME This PR/Issue is related to core FRAME, the framework. T12-benchmarks This PR/Issue is related to benchmarking and weights.

Comments

@shawntabrizi
Copy link
Contributor

shawntabrizi commented Nov 30, 2021 •
edited

See: paritytech/polkadot#3940 (comment)

We should add a CLI flag which will change the behavior of how to handle BenchmarkErrors.

For example, returning an error if Skip is reached when not expected.

Also a CLI flag for ignoring certain benchmarks would be nice to have.

Benchmark CLI found: https://github.com/paritytech/substrate/tree/master/utils/frame/benchmarking-cli
@shawntabrizi shawntabrizi mentioned this issue Nov 30, 2021
Merged
@Szegoo
Copy link
Contributor

Szegoo commented Jun 15, 2022

@shawntabrizi I would like to give this a try, I am going to make an early pull request so you can check if I am on the right track.

@Szegoo Szegoo mentioned this issue Jun 15, 2022
Closed
@juangirini juangirini transferred this issue from paritytech/substrate Aug 24, 2023
@the-right-joyce the-right-joyce added C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. T1-FRAME This PR/Issue is related to core FRAME, the framework. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. and removed Z6-mentor labels Aug 25, 2023
helin6 pushed a commit to boolnetwork/polkadot-sdk that referenced this issue Feb 5, 2024
@sorpaas
Standalone backend database for Frontier (paritytech#295)
918c11b 
* Init fc-db crate

* Intergrate fc_db into rpc and consensus module
@ggwpez ggwpez added the T12-benchmarks This PR/Issue is related to benchmarking and weights. label Feb 5, 2024
@ggwpez
Copy link
Member

ggwpez commented Mar 13, 2024

Also a CLI flag for ignoring certain benchmarks would be nice to have.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. T1-FRAME This PR/Issue is related to core FRAME, the framework. T12-benchmarks This PR/Issue is related to benchmarking and weights.
Projects
Runtime / FRAME
Status: Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

skipping certain benchmarks Szegoo/substrate
5 participants
@shawntabrizi @juangirini @ggwpez @Szegoo @the-right-joyce