Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use common overseer construction codepath for polkadot node + collator #3116

Closed
skunert opened this issue Jan 29, 2024 · 3 comments · Fixed by #3335
Closed

Use common overseer construction codepath for polkadot node + collator #3116

skunert opened this issue Jan 29, 2024 · 3 comments · Fixed by #3335
Assignees
@maksimryndin
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D1-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase. I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue. T0-node This PR/Issue is related to the topic “node”.

Comments

@skunert
Copy link
Contributor

skunert commented Jan 29, 2024

Ideally we would use the same codepath for construction of the overseer for collator and polkadot node.
This requires some investigation and fiddling around with the traits.

For a rough idea check this comment.

Derived from #3061
@skunert skunert added T0-node This PR/Issue is related to the topic “node”. I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue. D1-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase. labels Jan 29, 2024
@maksimryndin
Copy link
Contributor

@skunert @s0me0ne-unkn0wn hi! could I take this issue to investigate and try to solve? (disclaimer: I am an external contributor)

@skunert
Copy link
Contributor Author

skunert commented Feb 13, 2024

From my side yes, would be greatly appreciated! 👍

@s0me0ne-unkn0wn
Copy link
Contributor

Would be great, I wouldn't have a chance to take it in the near future anyway ;)

@s0me0ne-unkn0wn s0me0ne-unkn0wn added the C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. label Feb 13, 2024
@maksimryndin maksimryndin mentioned this issue Feb 15, 2024
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Feb 28, 2024
@maksimryndin @ordian @s0me0ne-unkn0wn
Collator overseer builder unification (#3335)
7ec0b87 
resolve #3116

a follow-up on
#3061 (review):

- [x] reuse collator overseer builder for polkadot-node and collator
- [x] run zombienet test (0001-parachains-smoke-test.toml)
- [x] make wasm build errors more user-friendly for an easier problem
detection when using different toolchains in Rust

---------

Co-authored-by: ordian <write@reusable.software>
Co-authored-by: s0me0ne-unkn0wn <48632512+s0me0ne-unkn0wn@users.noreply.github.com>
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this issue Mar 25, 2024
@maksimryndin @ordian @s0me0ne-unkn0wn
Collator overseer builder unification (paritytech#3335)
4fbe140 
resolve paritytech#3116

a follow-up on
paritytech#3061 (review):

- [x] reuse collator overseer builder for polkadot-node and collator
- [x] run zombienet test (0001-parachains-smoke-test.toml)
- [x] make wasm build errors more user-friendly for an easier problem
detection when using different toolchains in Rust

---------

Co-authored-by: ordian <write@reusable.software>
Co-authored-by: s0me0ne-unkn0wn <48632512+s0me0ne-unkn0wn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maksimryndin maksimryndin

Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D1-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase. I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue. T0-node This PR/Issue is related to the topic “node”.
Projects
SDK Node
Status: done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Collator overseer builder unification maksimryndin/polkadot-sdk
3 participants
@skunert @maksimryndin @s0me0ne-unkn0wn