Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collator protocol: Provide parent head data #3128

Closed
Tracked by #1829
eskimor opened this issue Jan 30, 2024 · 1 comment · Fixed by #3302 or #3521
Closed
Tracked by #1829

collator protocol: Provide parent head data #3128

eskimor opened this issue Jan 30, 2024 · 1 comment · Fixed by #3302 or #3521
Assignees

Comments

@eskimor
Copy link
Member

eskimor commented Jan 30, 2024

Add an additional (backwards compatibility) advertise collation message, which triggers a different collation fetch request (requesting also the head data of the parent) -> Make use of that head data in candidate validation.

@ordian ordian added T9-cumulus This PR/Issue is related to cumulus. and removed T9-cumulus This PR/Issue is related to cumulus. labels Mar 11, 2024
github-merge-queue bot pushed a commit that referenced this issue Mar 15, 2024
Fixes #3128.

This introduces a new variant for the collation response from the
collator that includes the parent head data. For now, collators won't
send this new variant. We'll need to change the collator side of the
collator protocol to detect all the cores assigned to a para and send
the parent head data in the case when it's more than 1 core.

- [x] validate approach
- [x] check head data hash
@ordian ordian linked a pull request Mar 16, 2024 that will close this issue
@ordian
Copy link
Member

ordian commented Mar 16, 2024

reopening until #3521 is merged

@ordian ordian reopened this Mar 16, 2024
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this issue Mar 24, 2024
…ytech#3302)

Fixes paritytech#3128.

This introduces a new variant for the collation response from the
collator that includes the parent head data. For now, collators won't
send this new variant. We'll need to change the collator side of the
collator protocol to detect all the cores assigned to a para and send
the parent head data in the case when it's more than 1 core.

- [x] validate approach
- [x] check head data hash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
2 participants