Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error reporting for FRAME Macros #3489

Closed
gupnik opened this issue Feb 27, 2024 · 3 comments
Closed

Improve error reporting for FRAME Macros #3489

gupnik opened this issue Feb 27, 2024 · 3 comments
Assignees
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.

Comments

@gupnik
Copy link
Contributor

gupnik commented Feb 27, 2024

Generally within FRAME, the macro expansion exits as soon as some condition fails without generating rest of the code. This produces a cascade of errors resulting in poor dev experience.

Though it is not possible to fix it everywhere, a number of scenarios could be improved by aggregating all errors during the parsing phase and making the expansion phase infallible - but adding the aggregated errors along with the expansion.

#3478 serves as a good example.

CC: @bkchr @kianenigma

@gupnik gupnik added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Feb 27, 2024
@gupnik gupnik self-assigned this Feb 27, 2024
@kianenigma
Copy link
Contributor

related: #334

@kianenigma
Copy link
Contributor

but isn't this a duplicate of #213?

@gupnik
Copy link
Contributor Author

gupnik commented Mar 11, 2024

but isn't this a duplicate of #213?

Wasn't aware of it. Will close this one.

@gupnik gupnik closed this as completed Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
Status: Done
Development

No branches or pull requests

2 participants