Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subsystem-bench: Remove benchmark_name from BenchmarkUsage #3601

Closed
AndreiEres opened this issue Mar 6, 2024 · 2 comments · Fixed by #4540 · May be fixed by #3620
Closed

subsystem-bench: Remove benchmark_name from BenchmarkUsage #3601

AndreiEres opened this issue Mar 6, 2024 · 2 comments · Fixed by #4540 · May be fixed by #3620
Assignees
@olaitanade
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. R0-silent Changes should not be mentioned in any release notes T12-benchmarks This PR/Issue is related to benchmarking and weights.

Comments

@AndreiEres
Copy link
Contributor

AndreiEres commented Mar 6, 2024 •
edited

Since we print regression test results manually every time, we don't need to use benchmark_name inside BenchmarkUsage. We can just put the name inside println!.

polkadot-sdk/polkadot/node/subsystem-bench/src/lib/usage.rs

Lines 24 to 28 in 475e7a1

pub struct BenchmarkUsage {
pub benchmark_name: String,
pub network_usage: Vec<ResourceUsage>,
pub cpu_usage: Vec<ResourceUsage>,
}

@AndreiEres AndreiEres added R0-silent Changes should not be mentioned in any release notes C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. T12-benchmarks This PR/Issue is related to benchmarking and weights. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. labels Mar 6, 2024
@olaitanade
Copy link

Hi @AndreiEres, I'd like to work on this issue. Can you assign to me? Thanks.

@AndreiEres AndreiEres changed the title subsystem-bench: Deprecate benchmark_name in BenchmarkUsage subsystem-bench: Remove benchmark_name from BenchmarkUsage Mar 7, 2024
@AndreiEres
Copy link
Contributor Author

@olaitanade Sure, looking forward to your PR!

@olaitanade olaitanade mentioned this issue Mar 8, 2024
Open
@AndreiEres AndreiEres mentioned this issue May 22, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 28, 2024
@AndreiEres
[subsytem-bench] Remove redundant banchmark_name param (#4540)
3bf283f 
Fixes #3601

Since we print benchmark results manually, we don't need to save
benchmark_name anywhere, better just put the name inside `println!`.
hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this issue Jun 5, 2024
@AndreiEres @hitchhooker
[subsytem-bench] Remove redundant banchmark_name param (paritytech#4540)
b2e3ec0 
Fixes paritytech#3601

Since we print benchmark results manually, we don't need to save
benchmark_name anywhere, better just put the name inside `println!`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olaitanade olaitanade

Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. R0-silent Changes should not be mentioned in any release notes T12-benchmarks This PR/Issue is related to benchmarking and weights.
Projects
None yet
Milestone
No milestone
2 participants
@olaitanade @AndreiEres