Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.9.43] Expose both 9933 and 9944 ports #609

Closed
yli-onf opened this issue Jun 19, 2023 · 7 comments
Closed

[v0.9.43] Expose both 9933 and 9944 ports #609

yli-onf opened this issue Jun 19, 2023 · 7 comments

Comments

@yli-onf
Copy link

yli-onf commented Jun 19, 2023

I'm upgrading nodes to v0.9.43. I removed --rpc-port=9933 and replaced --ws-port=9944 with --rpc-port=9944, but an external call to port 9933 was not available (screenshot):
Screenshot 2023-06-19 at 1 09 39 PM (1)
Is there a way to expose both 9933 and 9944 for backward compatibility reason? If so, which parameter can I use?

@hugh-onf
Copy link

Thanks @yli-onf, in short, can we expose the RPC for more than one port? Thanks

@niklasad1
Copy link
Member

niklasad1 commented Jun 19, 2023

No, it's not possible unfortunately.

You could launch a load balancer that redirections 9944/9933 to 9944 as a workaround I guess...

@hugh-onf
Copy link

Thanks @niklasad1 we just try to learn if we can resolve this without code change on our end.
Btw, the node itself still support HTTP:9933 with 100 max connections limit right? I would suggest we keep it for backward compatibility as older version (yes we still have to support many networks with older versions) they don't have HTTP on 9944

@niklasad1
Copy link
Member

We have kept this a backward compatible option for a long time after we introduced the functionality to support both HTTP and WS on the same socket/port, see paritytech/substrate#13049 for more information. Perhaps should have a more verbose warning about it...

Sorry about this change but you can't really solve this without code change to support both 9933 and 9944 on a single polkadot node anymore, thus to workaround that temporary you would need to put behind a load balancer or something.

Btw, the node itself still support HTTP:9933 with 100 max connections limit right?

I don't understand this question, the number connection to RPC server (both the WS/HTTP) are managed by --rpc-max-connections. That is 100 by-default.

@Szymongib
Copy link

Hey, a piece of feedback from my side: for the future it would be good if changes like that could be highlighted in release notes.

@Sophia-Gold Sophia-Gold transferred this issue from paritytech/polkadot Aug 24, 2023
@chevdor
Copy link
Contributor

chevdor commented Aug 29, 2023

@Szymongib The fix was mentioned in this releasenotes.
The PR was breaking but mentioned as low prio so indeed not easy to spot.
FYI we are working on a better way to provide more accurate descriptions of changes, stay tuned,

@niklasad1
Copy link
Member

niklasad1 commented Aug 29, 2023

yeah, it was my fault I should have added a warning when starting up the node thatport 9944 will be removed soon....

It wasn't the intention for the beginning but was the only reasonable way forward.

@bkchr bkchr closed this as completed Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants