[WIP] Migrate from SignedExtension to TransactionExtension
#2454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: georgepisaltu <george.pisaltu@parity.io>
Signed-off-by: georgepisaltu <george.pisaltu@parity.io>
Signed-off-by: georgepisaltu <george.pisaltu@parity.io>
Signed-off-by: georgepisaltu <george.pisaltu@parity.io>
Signed-off-by: georgepisaltu <george.pisaltu@parity.io>
Signed-off-by: georgepisaltu <george.pisaltu@parity.io>
Signed-off-by: georgepisaltu <george.pisaltu@parity.io>
Signed-off-by: georgepisaltu <george.pisaltu@parity.io>
Signed-off-by: georgepisaltu <george.pisaltu@parity.io>
Signed-off-by: georgepisaltu <george.pisaltu@parity.io>
Signed-off-by: georgepisaltu <george.pisaltu@parity.io>
Signed-off-by: georgepisaltu <george.pisaltu@parity.io>
Signed-off-by: georgepisaltu <george.pisaltu@parity.io>
Signed-off-by: georgepisaltu <george.pisaltu@parity.io>
Signed-off-by: georgepisaltu <george.pisaltu@parity.io>
Signed-off-by: georgepisaltu <george.pisaltu@parity.io>
georgepisaltu
force-pushed
the
george-tx-ext
branch
from
6feb436
to
8aad0cf
Compare
Signed-off-by: georgepisaltu <george.pisaltu@parity.io>
Signed-off-by: georgepisaltu <george.pisaltu@parity.io>
Signed-off-by: georgepisaltu <george.pisaltu@parity.io>
Signed-off-by: georgepisaltu <george.pisaltu@parity.io>
Signed-off-by: georgepisaltu <george.pisaltu@parity.io>
gavofyork
reviewed
Nov 26, 2023
| let balances = vec![(ALICE, INITIAL_BALANCE)]; | ||
| let beneficiary: MultiLocation = | ||
| Junction::AccountId32 { network: None, id: ALICE.into() }.into(); | ||
| new_test_ext_with_balances(balances).execute_with(|| { |
There was a problem hiding this comment.
Suggested change
| new_test_ext_with_balances(balances).execute_with(|| { | |
| new_test_ext_with_balances(balances).execute_with(|| { |
gavofyork
reviewed
Nov 26, 2023
| @@ -14,7 +14,7 @@ readme = "README.md" | |||
| targets = ["x86_64-unknown-linux-gnu"] | |||
|
|
|||
| [dependencies] | |||
| tuplex = "0.1.1" | |||
| tuplex = { git = "https://github.com/gavofyork/tuplex.git", default-features = false } | |||
There was a problem hiding this comment.
Suggested change
| tuplex = { git = "https://github.com/gavofyork/tuplex.git", default-features = false } | |
| tuplex = "0.1.2" |
gavofyork
reviewed
Nov 26, 2023
| @@ -1,130 +0,0 @@ | |||
| // This file is part of Substrate. | |||
There was a problem hiding this comment.
Can't remove this - it's also for other people!
There was a problem hiding this comment.
Didn't think of that, I reverted the removal.
gavofyork
reviewed
Nov 26, 2023
Signed-off-by: georgepisaltu <george.pisaltu@parity.io>
Signed-off-by: georgepisaltu <george.pisaltu@parity.io>
Signed-off-by: georgepisaltu <george.pisaltu@parity.io>
Signed-off-by: georgepisaltu <george.pisaltu@parity.io>
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up effort on top of #2280
TransactionExtensionfor allSignedExtensionimplinstancesAsTransactionExtensionadapterSignedExtensionas deprecated and remove allSignedExtensionimpl` instancesSignedExtensionremnants in docs or other names