Snowbridge: Synchronize from Snowfork repository (#3761) #4829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR includes the following 2 improvements: Author: @yrong - #123 - #125 The Ethereum client syncs beacon headers as they are finalized, and imports every execution header. When a message is received, it is verified against the import execution header. This is unnecessary, since the execution header can be sent with the message as proof. The recent Deneb Ethereum upgrade made it easier to locate the relevant beacon header from an execution header, and so this improvement was made possible. This resolves a concern @svyatonik had in our initial Rococo PR: paritytech#2522 (comment) Author: @yrong - #118 When the AH sovereign account (who pays relayer rewards) is depleted, the inbound message will not fail. The relayer just will not receive rewards. Both these changes were done by @yrong, many thanks. ❤️ --------- Co-authored-by: claravanstaden <Cats 4 life!> Co-authored-by: Ron <yrong1997@gmail.com> Co-authored-by: Vincent Geddes <vincent@snowfork.com> Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>
|
What kind of testing has been done on this backport? |
|
|
@yrong may you do a final review here before Parity reviews, please? :) |
acatangiu
approved these changes
Jun 25, 2024
prdoc/pr_3761.prdoc
Outdated
| - audience: Runtime Dev | ||
| description: | | ||
| This PR improves the beacon client to send the execution header along with the message as proof and removes the verification and storing of all execution headers. | ||
| If the AH sovereign account is depleted and relayer rewards cannot be paid, the message should still be processed. |
There was a problem hiding this comment.
It is not, removed in 1877257. :) Good catch
|
The CI pipeline was cancelled due to failure one of the required jobs. |
acatangiu
merged commit 6dba07c
into
paritytech:release-crates-io-v1.7.0
16 of 127 checks passed
1 task
|
@Morganamilo the PR description has been updated to contain full set of crates needing patch update publish |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick from master of #3761, excluding PR Snowfork#118
Expected patches for (1.7.0):