Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Guide: Impose limits on the number of messages that a candidate can send #1534

Closed
pepyakin opened this issue Aug 4, 2020 · 1 comment · Fixed by #1556
Closed

Guide: Impose limits on the number of messages that a candidate can send #1534

pepyakin opened this issue Aug 4, 2020 · 1 comment · Fixed by #1556
Assignees
Labels
S0-design PR/Issue is in the design stage

Comments

@pepyakin
Copy link
Contributor

pepyakin commented Aug 4, 2020

See this comment

@pepyakin pepyakin added the S0-design PR/Issue is in the design stage label Aug 4, 2020
@pepyakin pepyakin self-assigned this Aug 4, 2020
@pepyakin
Copy link
Contributor Author

pepyakin commented Aug 5, 2020

In the current incarnation of the Router module it is a bit vague what exactly happens if either config.watermark_upward_queue_size or config.max_upward_queue_count are exceeded.

1. Dispatch queued upward messages from `RelayDispatchQueues` in a FIFO order applying the `config.watermark_upward_queue_size` and `config.max_upward_queue_count` limits.

My current thinking is the candidate acceptance function should fail if any of those limits are exceeded. Additionally, in light of #1539 these conditions should be checkable using only NonPersistedValidationData.

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
S0-design PR/Issue is in the design stage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant