Comprehensive tests for polkadot-network #202

gterzian · 2019-04-01T09:29:52Z

gterzian · 2019-05-14T08:56:41Z

Putting this one on-ice, until the substrate networking code settles down into it's new configuration...

ltfschoen · 2019-07-31T02:18:03Z

network/src/tests/mod.rs

+impl JustificationImport<Block> for ForceFinalized {
+	type Error = ConsensusError;
+
+	fn import_justification(


these arguments could fit on a single line (it'd be no longer than https://github.com/paritytech/polkadot/pull/202/files#diff-383209c932e7187683ba4eea46d5b30dR95)

ltfschoen

nitpick

gitcoinbot · 2019-10-11T07:58:20Z

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Workers have applied to start work.

These users each claimed they can complete the work by 11 months, 3 weeks ago.
Please review their action plans below:

1) fight4g8code has applied to start work (Funders only: approve worker | reject worker).

@vs77bb

Is this open issue still active?
I have some time over the next 2.5 weeks to tackle this issue. Is there some more detailed information on the issue?

Thanks

Learn more on the Gitcoin Issue Details page.

bkchr · 2019-10-13T17:16:51Z

@vs77bb this issue should still be available.

gitcoinbot · 2019-10-14T16:15:45Z

@fight4g8code Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

reminder (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot · 2019-10-17T16:15:49Z

@fight4g8code Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

reminder (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot · 2019-10-17T16:15:52Z

@fight4g8code Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

reminder (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot · 2019-10-20T16:15:41Z

@fight4g8code Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

reminder (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot · 2019-10-20T16:15:45Z

@fight4g8code Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

reminder (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

kianenigma · 2019-10-21T08:04:58Z

is this stale or will it be worked on by anyone?

thiolliere · 2019-10-21T11:45:13Z

also @amaurymartiny told me about chaos network test in javascript, is that related ?

bkchr · 2019-10-21T11:46:26Z

Probably on a more high level, but we need more integration tests.

thiolliere · 2019-10-21T12:04:52Z

for information https://gitlab.parity.io/parity/infrastructure/parity-testnet/

amaury1093 · 2019-10-21T12:17:21Z

We had a small chat some time ago about whether the chaos-net should do e2e tests like these ones, and I don't think it would fit here.

Reasons:

the chaos net handles stuff like managing Kubernetes nodes (via the Kubernetes sdk), and I don't think putting such code in this repo would be a good idea (rust core devs might not all be interested in writing devops-related code).
the chaos net is all written in JS (because right now polkadotjs api is the best way to communicate with substrate metadata-based chains). I don't think we should put JS code in this repo.
overall the chaos net will be an independent project with a project owner, so for now everything chaos-net lives in its own repo (the one Guillaume put just above).

Once the chaos net stabilizes a bit, there might be a possibility to add to offer a way for these PRs to spawn an E2E test in the chaos net (or in a chaos-net clone). But for the near future that is not happening.

gitcoinbot · 2019-10-26T16:15:48Z

@fight4g8code Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

reminder (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot · 2019-10-26T16:15:50Z

@fight4g8code Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

reminder (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot · 2019-10-29T16:15:53Z

@fight4g8code Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

reminder (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot · 2019-10-29T16:15:56Z

@fight4g8code Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

reminder (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot · 2019-11-01T16:15:49Z

@fight4g8code Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

reminder (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot · 2019-11-01T16:15:51Z

@fight4g8code Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

reminder (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot · 2019-11-04T17:15:32Z

@fight4g8code Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

reminder (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot · 2019-11-04T17:15:35Z

@fight4g8code Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

reminder (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot · 2019-11-07T17:15:36Z

@fight4g8code Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

reminder (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot · 2019-11-07T17:15:39Z

@fight4g8code Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

reminder (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot · 2019-11-10T17:15:29Z

@fight4g8code Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

reminder (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot · 2019-11-10T17:15:31Z

@fight4g8code Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

reminder (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot · 2019-11-13T17:15:30Z

@fight4g8code Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

reminder (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot · 2019-11-13T17:15:32Z

@fight4g8code Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

reminder (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot · 2019-11-16T17:15:33Z

@fight4g8code Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

reminder (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot · 2019-11-16T17:15:36Z

@fight4g8code Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

reminder (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot · 2019-11-19T17:15:32Z

@fight4g8code Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

reminder (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot · 2019-11-19T17:15:35Z

@fight4g8code Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

reminder (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot · 2019-11-22T17:15:44Z

@fight4g8code Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

reminder (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot · 2019-11-22T17:15:48Z

@fight4g8code Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

reminder (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot · 2019-11-25T17:15:30Z

@fight4g8code Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

reminder (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

…ge (paritytech#202) * Update Polkadot reference and remove `ValidationFunction` to make usage with polkadot-js easier * Update again

initial setup

69e1069

gterzian added the A3-in_progress Pull request is in progress. No review needed at this stage. label Apr 1, 2019

gterzian mentioned this pull request Apr 1, 2019

Remove Clone bound on specialization in TestNetFactory paritytech/substrate#2157

Merged

use test block

84f1dbd

gterzian added the A1-onice label May 14, 2019

ltfschoen reviewed Jul 31, 2019

View reviewed changes

gavofyork closed this Nov 8, 2019

Comprehensive tests for polkadot-network #202

Comprehensive tests for polkadot-network #202

Conversation

gterzian commented Apr 1, 2019

gterzian commented May 14, 2019 • edited

ltfschoen Jul 31, 2019 • edited

Choose a reason for hiding this comment

ltfschoen left a comment

Choose a reason for hiding this comment

gitcoinbot commented Oct 11, 2019

bkchr commented Oct 13, 2019

gitcoinbot commented Oct 14, 2019

gitcoinbot commented Oct 17, 2019

gitcoinbot commented Oct 17, 2019

gitcoinbot commented Oct 20, 2019

gitcoinbot commented Oct 20, 2019

kianenigma commented Oct 21, 2019

thiolliere commented Oct 21, 2019

bkchr commented Oct 21, 2019

thiolliere commented Oct 21, 2019

amaury1093 commented Oct 21, 2019

gitcoinbot commented Oct 26, 2019

gitcoinbot commented Oct 26, 2019

gitcoinbot commented Oct 29, 2019

gitcoinbot commented Oct 29, 2019 • edited by bkchr

gitcoinbot commented Nov 1, 2019

gitcoinbot commented Nov 1, 2019 • edited by bkchr

gitcoinbot commented Nov 4, 2019

gitcoinbot commented Nov 4, 2019

gitcoinbot commented Nov 7, 2019

gitcoinbot commented Nov 7, 2019

gitcoinbot commented Nov 10, 2019

gitcoinbot commented Nov 10, 2019 • edited by arkpar

gitcoinbot commented Nov 13, 2019

gitcoinbot commented Nov 13, 2019

gitcoinbot commented Nov 16, 2019

gitcoinbot commented Nov 16, 2019

gitcoinbot commented Nov 19, 2019

gitcoinbot commented Nov 19, 2019

gitcoinbot commented Nov 22, 2019

gitcoinbot commented Nov 22, 2019

gitcoinbot commented Nov 25, 2019

gterzian commented May 14, 2019 •

edited

ltfschoen Jul 31, 2019 •

edited

gitcoinbot commented Oct 29, 2019 •

edited by bkchr

gitcoinbot commented Nov 1, 2019 •

edited by bkchr

gitcoinbot commented Nov 10, 2019 •

edited by arkpar