Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[zombienet]: fix misc-upgrade-node #7177

Closed
niklasad1 opened this issue May 4, 2023 · 6 comments
Closed

[zombienet]: fix misc-upgrade-node #7177

niklasad1 opened this issue May 4, 2023 · 6 comments
Assignees

Comments

@niklasad1
Copy link
Member

niklasad1 commented May 4, 2023

#6987 broke CLI arguments which in turn broke the test zombienet-tests-misc-upgrade-node which is temporarily disabled and should enabled again once there is polkadot release with the new CLI args.

@bkchr
Copy link
Member

bkchr commented May 4, 2023

Ty @niklasad1!

@pepoviola would it be possible for zombienet to support both CLI versions at the same time? Maybe with some kind of "switch" when declaring the node?

@pepoviola
Copy link
Contributor

Thanks for open this issue for tracking @niklasad1.

@bkchr, yes I will add the possibility to set the cli args version in the network definition. This will allow us to set the node we use for upgrade to not use the deprecated flags. I will work on that today and open a new pr to with the fixed version.
Thanks!!

@pepoviola
Copy link
Contributor

Issue in zombienet repo to track (paritytech/zombienet#1005).

@pepoviola
Copy link
Contributor

Hi @niklasad1, can we close this one since is already fixed in zombienet.
Thanks!

@niklasad1
Copy link
Member Author

if zombienet has bumped to a version with that fix just close this issue :)

@pepoviola
Copy link
Contributor

if zombienet has bumped to a version with that fix just close this issue :)

Closing, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants