This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
[CI] check_runtime.sh redux #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s3krit
added
B0-silent
github-actions
bot
added
the
A3-in_progress
github-actions
bot
added
A0-please_review
|
Most parachains-related code is within a separate folder |
gabreal
approved these changes
Jul 13, 2020
scripts/gitlab/check_runtime.sh
Outdated
| @@ -13,77 +13,75 @@ | |||
| # runtime/{polkadot,kusama}/src/lib.rs file | |||
|
|
||
| # Pretty-printing functions | ||
| boldprint () { printf "|\n| \033[1m%s\033[0m\n|\n" "${@}"; } | ||
| boldcat () { printf "|\n"; while read -r l; do printf "| \033[1m%s\033[0m\n" "${l}"; done; printf "|\n" ; } |
There was a problem hiding this comment.
nice finally made it into the lib :)
Hmm good point, will add that in, cheers |
|
@rphmeier requested changes implemented :) As soon as you give this a thumbs up I'll merge. |
rphmeier
approved these changes
Jul 15, 2020
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to redo check_runtime.sh to better support multiple runtimes. It defines a list of runtimes (currently kusama, polkadot and westend).
Outline of the new logic:
runtime/$runtime/*) orruntime/common/*, then look for any changes to Substrate between the last tag and the current commit. If any of them are labelled D1-breaksapi, then give this PR the same label. Then exit.spec_versionorimpl_versionhave not been bumped for that specific runtime since the last release, the test will fail and block merging the PR.master, label the PR with D2-breaksapiref https://github.com/paritytech/devops/issues/557