This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add claims prefix to the claims trait #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So we don't need to set any genesis config yet
rphmeier
reviewed
Jul 2, 2019
runtime/src/claims.rs
Outdated
| @@ -83,35 +83,12 @@ decl_storage! { | |||
| Total get(total) build(|config: &GenesisConfig<T>| { | |||
| config.claims.iter().fold(Zero::zero(), |acc: BalanceOf<T>, &(_, n)| acc + n) | |||
| }): BalanceOf<T>; | |||
| Prefix get(prefix) config(): Vec<u8>; | |||
There was a problem hiding this comment.
I had a comment here earlier that seems to have disappeared.
This should be a Get<&'static [u8]> param so we don't have to go to storage every time.
shawntabrizi
changed the title
|
@rphmeier thanks for the suggestion, I did not know you could do this. Hopefully all is good now. |
rphmeier
approved these changes
Jul 2, 2019
rphmeier
added
A8-looksgood
and removed
A0-please_review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #307
Prefixto the claims Trait