This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Dispute vote filtering for block authors #3498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A0-please_review
ordian
reviewed
Jul 20, 2021
ordian
reviewed
Jul 20, 2021
Co-authored-by: Andronik Ordian <write@reusable.software>
ordian
reviewed
Jul 20, 2021
…ytech/polkadot into rh-filter-runtime-disputes
drahnr
reviewed
Jul 20, 2021
Comment on lines
+533
to
+540
| indices.sort(); | ||
| indices.dedup(); | ||
|
|
||
| // reverse order ensures correctness | ||
| for index in indices.into_iter().rev() { | ||
| // swap_remove guarantees linear complexity. | ||
| statement_set.statements.swap_remove(index); | ||
| } |
drahnr
reviewed
Jul 20, 2021
runtime/parachains/src/disputes.rs
Outdated
Comment on lines
764
to
767
| let valid = match statement { | ||
| DisputeStatement::Valid(_) => true, | ||
| DisputeStatement::Invalid(_) => false, | ||
| }; |
There was a problem hiding this comment.
nit: adding a fn is_...(&self) -> bool would reduce the clutter a bit.
drahnr
approved these changes
Jul 20, 2021
andresilva
approved these changes
Jul 21, 2021
|
bot merge |
|
Waiting for commit status. |
|
Merge aborted: Checks failed for a4762ea |
ordian
added
D5-nicetohaveaudit ⚠️
|
(feel free to edit the audit label) bot merge |
ordian
added a commit
that referenced
this pull request
Jul 23, 2021
* master: Reduce staking miner reward (companion `substrate/pull/9395`) (#3465) Parachains shared.rs to Frame V2 (#3425) Parachains hrmp.rs to Frame V2 (#3475) Migrate slots pallet to pallet attribute macro. (#3218) Improve test in bridge (#3507) parachain dmp.rs to Frame V2 (#3426) Parachains inclusion.rs to Frame V2 (#3440) Dispute coordinator - Recover disputes on startup (#3481) Use correct syntax for owning all files in a folder (#3510) Add wococo-local chain spec (#3509) Dispute vote filtering for block authors (#3498) Bump indexmap from 1.6.1 to 1.7.0 (#3497) Companion for substrate #9315 (#3477)
jakoblell
added
D1-audited 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3472
When the node-side is authoring a block, it passes all votes from all disputes from recent sessions to an instance of the runtime as
InherentData. TheProvideInherentimplementation for theParasInherenthere invokes the filtering function, which is intended to detect duplicates and spam and so on.This pull request actually provides the implementation of that filtering logic, to be used to create
ParasInherentinherents that actually contain dispute votes so the chain can witness disputes.