Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Avoid bad pattern of wildcard fees #3578

Merged
merged 5 commits into from Aug 5, 2021
Merged

Avoid bad pattern of wildcard fees #3578

merged 5 commits into from Aug 5, 2021

Conversation

gavofyork
Copy link
Member

@gavofyork gavofyork commented Aug 5, 2021

Alters the two XCM dispatchables so that the BuyExecution uses the first Asset in the list to purchase fees, rather than MultiAsset::All, which is not a pattern that will be supported in the upcoming XCM v1.

Migration

pallet_xcm::Config has an extra item type LocationInverter. This should be the same definition as declared in the xcm_executor::Config, typically:

type LocationInverter = LocationInverter<Ancestry>;

@gavofyork gavofyork added A0-please_review Pull request needs code review. B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Aug 5, 2021
Copy link
Contributor

@KiChjang KiChjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise looks ok, I'm just wondering how we can enforce that the first element in the assets vector is going to be used for fee payment (or whether it is at all desirable in this point in time to have any such kind of enforcement, programmatically or otherwise).

@gavofyork gavofyork merged commit 67fd660 into master Aug 5, 2021
@gavofyork gavofyork deleted the gav-no-wildcard-fees branch August 5, 2021 15:44
@s3krit s3krit added this to the v0.9.9 milestone Aug 5, 2021
@gavofyork gavofyork mentioned this pull request Aug 6, 2021
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants