This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Dispute distribution improvements #3853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
eskimor
commented
Sep 15, 2021
eskimor
commented
- Add metric to see how long it takes to get a dispute vote out
- Only warn on failed transmission attempts, after the error rate reached a threshold
- Get rid of double logging
Network errors happen, only warn on a minimum number of failed attempts.
eskimor
added
A2-insubstantial
ordian
reviewed
Sep 15, 2021
| let error_rate = (100 * self.failed_count).checked_div(self.send_count).expect( | ||
| "We cannot receive a failed request, without having sent one first. qed.", | ||
| ); | ||
| // 10% seems to be a sensible threshold to become alarted - note that |
There was a problem hiding this comment.
I could not make up my mind 😆
| "Time needed for dispute votes to get confirmed/fail getting transmitted.", | ||
| ))?, | ||
| registry, | ||
| )?, |
There was a problem hiding this comment.
the default buckets are https://docs.rs/prometheus/0.12.0/src/prometheus/histogram.rs.html#25-27
There was a problem hiding this comment.
Yep, I think they are good enough.
ordian
approved these changes
Sep 15, 2021
ordian
added a commit
that referenced
this pull request
Sep 21, 2021
* master: weights: pallet-staking & pallet-bags-list (#3872) Re-enable metadata compare CI check (#3895) Bump `parity-util-mem` to 0.10.2 (#3897) Revert "remove connected disconnected state only (#3868)" (#3896) Companion for Generate storage info for pallet im_online #9654 (#3744) Gather memory usage statistics through `parity-util-mem` (#3893) ci: cache seed in fuzzer job (#3885) Add benchmarking for parachain runtime configuration pallet (#3862) Run fmt (#3887) remove connected disconnected state only (#3868) Dispute distribution improvements (#3853) Companion for Store voters in unsorted bags to get good stake iteration properties (#3413) Add info logging to dispute activation (#3870) update Rococo.json (#3871) Companion for #9764 (Force Unreserve) (#3840)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.