-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Conversation
I like the direction where it's headed. It's be good to see it applied to one subsystem to justify the design. |
be2b47e
to
433418a
Compare
9958fc4
to
e156b73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noice!
6a8edf8
to
adc568d
Compare
f6cf4eb
to
74c2a40
Compare
68f6146
to
783e15d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable overall. We should do a burn-in on Versi to make sure it doesn't introduce early exits or too verbose logging.
One think I prefer about our previous version is that the Fatal
, NonFatal
was explicit in the naming and here we have to jump to definition to know which one is fatal. But maybe it's not a big deal.
Technically we can also use the generated variants Could you outline an instance where you think the The logging verbosity should be identical to before. If there'd be a change that should be considered a bug. |
Deployed to versi group e for burnin and a |
Logs look good to me for the no disputes case (requires VPN) https://grafana.parity-mgmt.parity.io/explore?orgId=1&left=%5B%221645723532509%22,%221645723543309%22,%22loki.parity-testnet%22,%7B%22refId%22:%22A%22,%22expr%22:%22%7B%20node%20%3D~%20%5C%22versi-validator-a-.*%5C%22%20%7D%22%7D%5D |
Makes this more reviewable.
Avoid duplicate expander compilations.
8e64c98
to
99e6900
Compare
99e6900
to
c5d7d10
Compare
Did a last review pass to check the correct split between |
bot merge |
Waiting for commit status. |
Ref #4440
Note to reviewers:
#[fatal]
and#[fatal(forward)]
and the missing annotations with the previousenum
sNonFatal
andFatal
.trait Nested
ortrait Split
, these are easy to fixfatality::fatality
proc-macro