This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Update Crowdloan Account to FundIndex #4824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawntabrizi
commented
Feb 1, 2022
shawntabrizi
commented
Feb 1, 2022
Comment on lines
-661
to
662
| pub fn fund_account_id(index: ParaId) -> T::AccountId { | ||
| pub fn fund_account_id(index: FundIndex) -> T::AccountId { | ||
| T::PalletId::get().into_sub_account(index) |
There was a problem hiding this comment.
this is the main change, and UIs will need to update logic
shawntabrizi
commented
Feb 1, 2022
| #[pallet::getter(fn next_trie_index)] | ||
| pub(super) type NextTrieIndex<T> = StorageValue<_, u32, ValueQuery>; | ||
| #[pallet::getter(fn next_fund_index)] | ||
| pub(super) type NextFundIndex<T> = StorageValue<_, u32, ValueQuery>; |
There was a problem hiding this comment.
this is also a breaking change that needs to be migrated
paritytech-processbot bot
pushed a commit
that referenced
this pull request
Feb 12, 2022
* add support for parachain to parachain swap * enable swaps on kusama * sanity test in paras_registrar * express more errors * finish up tests * fmt * make fields pub * refactor integration tests to use real accounts * Update Crowdloan Account to FundIndex (#4824) * update fund account to use index * fix integration tests * Update runtime/common/src/crowdloan.rs * finish parachain swap test * format * fix warning * fix spacing * fix formatting * write migrations * add migration * fixes * more fixes to migration * Update runtime/common/src/crowdloan/mod.rs Co-authored-by: Zeke Mostov <z.mostov@gmail.com> * Update runtime/common/src/paras_registrar.rs * Update migration.rs * extract swap function Co-authored-by: Zeke Mostov <z.mostov@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4772