This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add pyroscope #4871
add pyroscope #4871
Changes from all commits
be73f3d
dab7ad2
6ed0b88
9a5196a
6fb1931
2ab9358
2515efd
37d6f8b
17f34a8
5e0a54f
57dbdc7
bcb4a8a
630cd06
c413cf7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need an address resolution here in the first place, counting that we reconstruct an URL afterwards? This URL can support more than plain
http
, for examplehttps
. I have no strong opinion here, but maybe it is better to name option likepyroscope_url
and treat it as an URL from the beginning?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two competing things: We want compatibility, but we also want URLs.
url::Url
does not accept an IP without a prefixed protocol such astcp://
orhttp://
- but we must maintain compatibility. The above is an escape hatch to reduce either to an IP address and avoid the ordeal.